Tor window uses Google.com by default

Description

On win10 x64, when I select the Open Tor Window option from the sync menu, the open Tor window uses google as the search engine.

Expected Tor default search engine: Tor default, global (except for France & Germany): duckduckgo.com Tor default, France & Germany: qwant.com

Steps to Reproduce

1. Click on the sync menu
2. Open New Tor Window:
3. Enter a keyword into the URL bar. Observe Google.com search results.

Actual result:

Google.com results.

Expected result:

DDG results (global, except for France and Germany) Qwant results (France, Germany)

Reproduces how often:

100%

Brave version (chrome://version info)

Brave | 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
-- | --
Revision | 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS | Windows
JavaScript | V8 7.0.276.9
Flash | (Disabled)
User Agent | Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.16 Safari/537.36
Command Line | "C:\Program Files (x86)\BraveSoftware\Brave-Browser-Dev\Application\brave.exe" --enable-tab-audio-muting --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=EnableEmojiContextMenu,DesktopPWAWindowing,fill-on-account-select,NewExtensionUpdaterService --disable-features=SharedArrayBuffer --flag-switches-begin --flag-switches-end

Reproducible on current release:

no

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

[simonhong]

I’ll take a look at this issue - I implemented private search engine in private window feature.

[darkdh]

@simonhong tor window is different than private window. It is a type of guest window with only persistent search engine setting. I recommend setting kDefaultSearchProviderDataPrefName when tor profile created and prevent ProfileManager::SetNonPersonalProfilePrefs from clearing it.