twitter banner/tipping mismatch issues

Description

Sometimes when tipping a Twitter user, there is a mismatch of information on the tip banner, the thank you banner, and if applicable, pending contributions (potentially tips panel as well).

Steps to Reproduce

1. Clean profile.
2. Enable Rewards. Fund wallet or restore a wallet. (I didn’t use KYC’d wallet here, using anon wallet.)
3. Login to Twitter.
4. Navigate to a user’s twitter page.
5. Click on in-line tip button and tip user (user I tipped unverified, not sure if it matters).
6. Navigate to a different user’s twitter page.
7. Click on in-line tip button, view banner, but don’t tip.
8. Repeat steps 6-7 several times until you see a mismatch of info on Tipping banner.
9. Once you see the mismatch, actually tip.
10. Mismatch is displayed on thank you banner as well.
11. Furthermore, if you tipped an unverified pub in step 5/9, when you go to view your pending contributions, there’s a serious mismatch - it looks like you tipped one of the people from the banner, but when you click on the Site in the table, you’ll be taken to a page with your own info.

Actual result:

Gif picks up from step 8 above:

Note that when the tip banner displays, there’s a mix of info for bcrypt and torproject. After tipping when the thank you banner comes up, it says bcrypt but you were trying to tip torproject. When you go to pending contributions table and click on the sites, it looks like bcrypt is listed, however when you click on the site in the table, you see your own info. (bcrypt was who I tipped in step 5 btw)

Expected result:

All info on tipping banner, thank you banner, and pending contributions (or actual tip table), should be for the intended recipient.

Reproduces how often:

easily

Brave version (brave://version info)

Brave	0.69.100 Chromium: 76.0.3809.87 (Official Build) dev (64-bit)
Revision	111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS	Mac OS X

Brave	0.70.44 Chromium: 76.0.3809.100 (Official Build) nightly (64-bit)
Revision	ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS	Mac OS X

Version/Channel Information:

• Can you reproduce this issue with the current release? no, could not reproduce on 0.67.x
• Can you reproduce this issue with the beta channel? no, could not reproduce on 0.68.x
• Can you reproduce this issue with the dev channel? yes, reproduced on 0.69.x
• Can you reproduce this issue with the nightly channel? yes, reproduced on 0.70.x

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @mandar-brave @NejcZdovc @brave/legacy_qa

[kjozwiak]

Reproduced this several on macOS 10.14.5 x64 using the following build:

Brave	0.70.46 Chromium: 76.0.3809.100 (Official Build) nightly (64-bit)
Revision	ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS	Mac OS X

Other examples:

[NejcZdovc]

thank you are for really pushing hard on testing this one. Will close it for now and let’s reopen it if we still have problems