question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update Brave Talk URL in Sidebar to talk.brave.com

See original GitHub issue

Description

Update Brave Talk URL in Sidebar to talk.brave.com; once https://github.com/brave/devops/issues/5168 lands, and creates an HTTP 301 Permanent Redirect from together.brave.com -> talk.brave.com, I think the following code might break Brave Talk in the Sidebar:

https://github.com/brave/brave-core/blob/ea66a8c49ade46d0d3d892626e7eea0948a95e09/components/sidebar/sidebar_service.cc#L36

https://github.com/brave/brave-core/blob/d9d0401c82d99284af60f7c81779aa632a136286/browser/ui/views/sidebar/sidebar_items_contents_view.cc#L393

Screen Shot 2021-06-30 at 9 30 19 AM

Steps to Reproduce

  1. after https://github.com/brave/devops/issues/5168 lands:
  2. enable Sidebar via brave://flags and restart Brave
  3. click on the video-camera icon in the Sidebar for Brave Talk
  4. ensure it still loads and launches talk.brave.com via its Start video call button

Reproduces how often:

Unsure; this is pre-emptively filed to try to avoid/mitigate breakage on nightly.

Brave version (brave://version info)

Brave 1.28.37 Chromium: 91.0.4472.124 (Official Build) nightly (x86_64)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS macOS Version 11.4 (Build 20F71)

/cc @rebron @simonhong @mattmcalister @mrose17 casting the net wide; trying to get our in-product renaming done so there are no late surprises 👍

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
simonhongcommented, Jul 21, 2021
0reactions
stephendonnercommented, Jul 23, 2021

Verified FIXED using

Brave 1.29.20 Chromium: 92.0.4515.107 (Official Build) nightly (x86_64)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS macOS Version 12.0 (Build 21A5284e)

(Although I made the earlier patch, it got backed out, so I feel it’s ok to verify @simonhong’s fix.)

Steps:

  1. new profile
  2. launched Brave
  3. enabled Sidebar via brave://flags
  4. relaunched
  5. launched Charles Proxy and listened for traffic
  6. clicked on the Brave Talk menu item in the sidebar
  7. clicked on Start call

Confirmed that traffic went to talk.brave.com, as expected.

Screen Shot 2021-07-22 at 5 23 07 PM
Read more comments on GitHub >

github_iconTop Results From Across the Web

How do I use Brave Sidebar? - Brave Help Center
Brave Talk - This shortcut takes you to talk.brave.com to quickly start a meeting. Brave Wallet - This shortcut allows easy access to...
Read more >
Re-order BM or Brave talk settings in the sidebar ... - GitHub
Description re-order BM or Brave talk settings in the sidebar menu in normal window leads to lose the focus on existing window Steps...
Read more >
Brave Talk is now available in the Brave Browser - YouTube
This private chat gives you unlimited video calls.Keep an eye out for fresh content uploaded regularly.#windows11 #windows10 #windowsupdate ...
Read more >
Brave Software - Twitter
Video chat with them for free with Brave Talk! Brave Talk offers private video chats for up to 4 people with no time...
Read more >
Brave 1.37: new sidebar, custom new tab backgrounds and ...
As far as the sidebar in Brave is concerned, it displays links to Brave Wallet and Brave Talk, and you may add any...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found