Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update search engine defaults for AT / ES / MX

See original GitHub issue

Description

Update search engine defaults for:

Austria (AT)
Spain (ES)
Mexico (MX)

Brave should be at the top of drop down list at brave://settings/search

Test plan

Region set to AT / ES / MX

Fresh profile
Search onboarding should NOT be shown
Default search engine SHOULD be Brave
Visit brave://settings/searchEngines
Brave SHOULD be first in the Default search engines list

Region set to anything else (excluding CA / DE / FR / GB / US)

Fresh profile
Search onboarding SHOULD be shown
Default will NOT be Brave Search
Visit brave://settings/searchEngines
Brave SHOULD be first in the Default search engines list - unless you’re in a region where Yandex is default (AM, AZ, BY, KG, KZ, MD, RU, TJ, TM, UZ). In that case it will be second.

Issue Analytics

State:
Created a year ago
Comments:7 (3 by maintainers)

Top GitHub Comments

1reaction

kjozwiakcommented, Jul 26, 2022

@brave/qa-team as discussed with @rebron, we don’t need to run through each locale like I did via https://github.com/brave/brave-core/pull/14177#issuecomment-1195042499 on Nightly before uplifted. On each platform, we can check the following:

single check on either AT, ES or MX
single check on either CA, DE, FR, GB or US
single check of a locale that isn’t listed above to ensure that Brave Search isn’t default and the search screen is still visible via brave://welcome during onboarding.

Please coordinate so we’re not doing the same locales twice when verifying via 1.42.x.

0reactions

btlechowskicommented, Jul 29, 2022

Verification passed on

Brave	1.42.81 Chromium: 104.0.5112.69 (Official Build) (64-bit)
Revision	7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS	Ubuntu 18.04 LTS

Verified the test plan from https://github.com/brave/brave-browser/issues/23814#issue-1290770631

ES (Spain) locale

`Case #1` - https://github.com/brave/brave-browser/issues/23908

brave://welcome

Using the STR/Cases outlined via https://github.com/brave/brave-browser/issues/23908#issue-1296549984 and ensured that the Set default search engine screen was removed from brave://welcome as per the following:

`Case #2` - https://github.com/brave/brave-browser/issues/23814

Clean Profile

ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
ensured that Brave was selected as the default via brave://settings/searchEngines

Updated Profile (Google/Google)

installed 1.41.x
ensured that Google was the default SE selected under brave://settings/search
updated to 1.42.x and ensured that Google is still the default SE in both Normal and Private windows SE
- ensured that it wasn’t replaced by Brave
ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

1.41.x

1.42.x

Updated Profile (Startpage/DDG)

installed 1.41.x
ensured that Startpage was the default SE selected under brave://settings/search
updated to 1.42.x and ensured that previously selected SE is still the default for both Normal and Private windows
- ensured that it wasn’t replaced by Brave
ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

Updated Profile (Ecosia/Qwant)

installed 1.41.x
ensured that Ecosia was the default SE selected under brave://settings/search
updated to 1.42.x and ensured that previously selected SE is still the default for both Normal and Private windows
- ensured that it wasn’t replaced by Brave
ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

As per https://github.com/brave/brave-browser/issues/23908, ensured that locales from CA / DE / FR / GB / US are not displaying the Set default search engine screen via brave://welcome (onboarding).

de locale

Case #1 - https://github.com/brave/brave-browser/issues/23908

brave://welcome

Case #2 - https://github.com/brave/brave-browser/issues/23814

Clean Profile

ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
ensured that Brave was selected as the default via brave://settings/searchEngines

Updated Profile (Brave/Brave)

installed 1.41.x
ensured that Brave was the default SE selected under brave://settings/search
updated to 1.42.x and ensured that Brave is still the default SE
ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

Updated Profile (DDG/Startpage)

installed 1.41.x
ensured that DDG was the default SE selected under brave://settings/searchEngines for Normal windows and
updated to 1.42.x and ensured that previously selected SE is still the default for both Normal and Private windows
- ensured that it wasn’t replaced by Brave
ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

1.41.x

1.42.x

Checking to ensure that locales that don’t have Brave Search as the default and still have the Set default search engine screen screen via brave://welcome (onboarding) are working as expected.

PL locale

Case #1 - https://github.com/brave/brave-browser/issues/23908

brave://welcome

Using the STR/Cases outlined via https://github.com/brave/brave-browser/issues/23908#issue-1296549984 and ensured that the Set default search engine screen was not removed from brave://welcome as per the following:

Case #2 - https://github.com/brave/brave-browser/issues/23814

Clean Profile

ensured that Google was selected as the default for both Normal/Private windows via brave://settings/search
ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
ensured that Google was selected as the default via brave://settings/searchEngines

Updated Profile (Google/Google)

installed 1.41.x
ensured that Google was the default SE selected under brave://settings/search
updated to 1.42.x and ensured that Google is still the default SE in both Normal and Private window SE
ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

Updated Profile (Qwant/Bing)

installed 1.41.x
ensured that Qwant was the default SE selected under brave://settings/search
updated to 1.42.x and ensured that previously selected SE is still the default for both Normal and Private windows
- ensured that it wasn’t replaced by Brave
ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows