question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

US country code incorrectly stripped from P3A reports

See original GitHub issue

Description

In #21460 I inadvertently stripped the US country code from P3A report metadata. This is an important region with many users, so stripping it harms our understanding of browser use without improving user privacy.

US should be added to the list of generally-accepted country codes for reporting.

Steps to Reproduce

  1. Install with US locale
  2. Observe P3A report metadata

Actual result:

Country code is other

Expected result:

Country code should be US.

Reproduces how often:

Always

Desktop Brave version:

1.38.28

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:9

github_iconTop GitHub Comments

1reaction
Uni-versecommented, Apr 21, 2022

Verified using 1.38.104, Chromium 101.0.4951.41 on Samsung Galaxy S21 running Android 12

  • Confirmed country_code: us is being appended to the request
  • Confirmed that “country_code” is “US” in JSON message
1 2
Screen Shot 2022-04-21 at 11 39 05 AM Screen Shot 2022-04-21 at 11 43 59 AM
1reaction
rilliancommented, Apr 5, 2022

@GeetaSarvadnya, the country code sent with P3A message is derived from the timezone rather than the locale. So if you set the system timezone to US/Eastern, America/New York, or similar you should see the expected US country code in P3A reports, independent of the configured language or other locale settings.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Remove refcode from P3A reports · Issue #21460 - GitHub
Remove refcode field from P3A messages brave/brave-core#12478 ... US country code incorrectly stripped from P3A reports #21534.
Read more >
Strange Country Code Problem Causing Messages to Not ...
I am trying to get this corrected without fully deleting the conversation and get the message back to RCS.
Read more >
Messages app adding (wrong) country code after foreign trip
Today I tried "Add Contact" for one of these from Messages and noticed that Messages is trying to add a country code (+49...
Read more >
Multipart SMS getting mixed up with old messages [36929744]
Such a big bug is reported with Priority-Medium: Android does not care that it's OS is mixing messages and people get the wrong...
Read more >
China-U.S. Aircraft Collision Incident of April 2001
The serious incident of April 2001 between the United States and the People's. Republic of China (PRC) involved a collision over the South ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found