Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Users are not rewarded for viewing an NTP SI until the browser is restarted

See original GitHub issue

Description

Users are not rewarded for viewing an NTP SI until the browser is restarted.

Steps to Reproduce

Scenario 1:

Clean profile 1.19.86
Enable rewards & Ads via brave://rewards
Upgrade to 1.19.88
View an NTP SI
Users are not rewarded for viewing NTP SI
Restart the browser fixes the issue

Scenario 2:

Clean profile 1.19.86
Enable rewards and disable Ads
Upgrade to 1.19.88 and enable Ads
View an NTP SI
Users are not rewarded for viewing NTP SI
Restart the browser fixes the issue

Note: Restart browser fixes the issue only for US locale not for India

Actual result:

Users are not rewarded for viewing an NTP SI until the browser is restarted

[14580:13968:0128/183408.571:INFO:creative_new_tab_page_ads_database_table.cc(426)] Failed to get creative new tab page ad
[14580:13968:0128/183408.571:VERBOSE1:new_tab_page_ad.cc(77)] Failed to fire new tab page ad event for wallpaper id

Expected result:

Users should be rewarded for viewing an NTP SI without a browser restart

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.19.88 Chromium: 88.0.4324.96 (Official Build) (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	Windows 10 OS Version 2004 (Build 19041.746)

Version/Channel Information:

Can you reproduce this issue with the current release? No
Can you reproduce this issue with the beta channel? No
Can you reproduce this issue with the nightly channel? No

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? NA
Does the issue resolve itself when disabling Brave Rewards? NA
Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @tmancey @jsecretan @rebron

Issue is Reproduced by @btlechowski for poland region

Issue Analytics

State:
Created 3 years ago
Comments:10 (3 by maintainers)

Top GitHub Comments

1reaction

LaurenWagscommented, May 4, 2022

Verified with

Brave | 1.39.89 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
-- | --
Revision | 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS | macOS Version 12.3.1 (Build 21E258)

Brave - ads enabled, catalog downloaded before upgrade from 1.38.x - PASSED

Verified catalog was downloaded after upgrade to 1.39.x

[1898:259:0504/082841.191289:VERBOSE1:ad_server.cc(80)] OnGetCatalog
[1898:259:0504/082841.192952:VERBOSE1:ad_server.cc(88)] Successfully fetched catalog
[1898:259:0504/082841.192975:VERBOSE1:ad_server.cc(90)] Parsing catalog

Verified NTPSI was shown:

Verified user was paid for the NTPSI

[1898:259:0504/084200.342354:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id df27db19-bfaa-4ec9-93e2-1a0eff060188 and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
.........
[1898:259:0504/084200.343953:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
.............
[1898:259:0504/084200.368130:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id df27db19-bfaa-4ec9-93e2-1a0eff060188 and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
[1898:259:0504/084200.369639:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view valued at 0.01
[1898:259:0504/084200.369691:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id c8b79f0b-0c95-4e95-b567-8ed6cb699969 and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
.........
[1898:259:0504/084200.371593:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event
.........
[1898:259:0504/084221.572898:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id b3fba0b3-5dc9-4de6-99a7-05e1bae85917, transaction id c8b79f0b-0c95-4e95-b567-8ed6cb699969, creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view. You now have 1 unblinded payment tokens which will be redeemed on Friday, May 6, 2022 at 10:20:14 AM

Brave - ads enabled, catalog not downloaded before upgrade from 1.38.x - PASSED

Made sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500

[2952:259:0504/091316.701704:VERBOSE1:ad_server.cc(81)] OnGetCatalog
[2952:259:0504/091316.701958:VERBOSE1:ad_server.cc(111)] Failed to parse catalog

Verified catalog was downloaded after upgrade to 1.39.x

[3170:259:0504/091517.852882:VERBOSE1:ad_server.cc(80)] OnGetCatalog
[3170:259:0504/091517.854126:VERBOSE1:ad_server.cc(88)] Successfully fetched catalog
[3170:259:0504/091517.854156:VERBOSE1:ad_server.cc(90)] Parsing catalog

Verified NTPSI was shown

Verified user was paid for the NTPSI

[3170:259:0504/091625.131956:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 835a2696-d550-45f9-b624-1c339c116b9b and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
.........
[3170:259:0504/091625.134004:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
.........
[3170:259:0504/091625.156030:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 835a2696-d550-45f9-b624-1c339c116b9b and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
[3170:259:0504/091625.158021:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view valued at 0.01
[3170:259:0504/091625.158094:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id 93285d7a-370a-4040-bd22-a1bb749ffaa3 and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
..........
[3170:259:0504/091656.474766:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id ade2aa05-85c2-4d58-a919-bc8ad1cf0659, transaction id 93285d7a-370a-4040-bd22-a1bb749ffaa3, creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view. You now have 1 unblinded payment tokens which will be redeemed in 9 hours, 29 minutes, 15 seconds at 18:46:11.581

Brave - ads re-enabled, catalog downloaded before upgrade from 1.38.x - PASSED

In 1.38.x:

[4637:259:0504/102735.026282:VERBOSE1:ads_service_impl.cc(707)] Shutting down ads
[4637:259:0504/102735.027957:VERBOSE1:ads_service_impl.cc(723)] Successfully shutdown ads

Verified user was paid for the NTPSI

[4765:259:0504/102931.331045:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id fd5b3310-0ea0-4e61-b89b-f8a3973d2c0e and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
...........
[4765:259:0504/102931.333528:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
..........
[4765:259:0504/102931.358295:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id fd5b3310-0ea0-4e61-b89b-f8a3973d2c0e and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
[4765:259:0504/102931.359773:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view valued at 0.01
[4765:259:0504/102931.359861:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id 7a73b3a6-0e51-47fa-ab1a-372ceb6491a0 and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
...........
[4765:259:0504/103009.654513:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id 1aaa16ce-9d75-41ed-9eca-37975dc86112, transaction id 7a73b3a6-0e51-47fa-ab1a-372ceb6491a0, creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view. You now have 1 unblinded payment tokens which will be redeemed on Friday, May 6, 2022 at 4:33:15 AM

Brave - ads re-enabled, catalog not downloaded before upgrade from 1.38.x - PASSED

Made sure that catalog was not downloaded on 1.38.x by overriding the response code 200->500

[5186:259:0504/104445.972657:VERBOSE1:ad_server.cc(81)] OnGetCatalog
[5186:259:0504/104445.972895:VERBOSE1:ad_server.cc(111)] Failed to parse catalog

In 1.38.x:

[5186:259:0504/104549.516886:VERBOSE1:ads_service_impl.cc(707)] Shutting down ads
[5186:259:0504/104549.518918:VERBOSE1:ads_service_impl.cc(723)] Successfully shutdown ads

Verified user was paid for the NTPSI after upgrade

[5377:259:0504/104734.771275:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 018e47ac-932e-4cc0-8d45-550345bd64fe and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
..........
[5377:259:0504/104734.773208:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
.......
[5377:259:0504/104734.797689:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 018e47ac-932e-4cc0-8d45-550345bd64fe and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
[5377:259:0504/104734.800560:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view valued at 0.01
[5377:259:0504/104734.800646:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id c0921435-2788-4933-b961-f5fd8d051e63 and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
........
[5377:259:0504/104755.268534:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id 396bbf4f-4bcb-46c5-965b-bddc4faa9a99, transaction id c0921435-2788-4933-b961-f5fd8d051e63, creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view. You now have 1 unblinded payment tokens which will be redeemed in 7 hours, 37 minutes, 55 seconds at 18:25:50.723

Brave - ads enabled, catalog downloaded before upgrade from 1.19.86 - PASSED

Installed 1.19.86 and enabled rewards and ads Because it is an old version, catalog failed to parse:

[5764:259:0504/110222.764004:VERBOSE1:ad_server.cc(109)] Failed to parse catalog

Also the wallet failed to be created.

Verified catalog was downloaded after upgrade to 1.39.x

[5956:259:0504/110424.521619:VERBOSE1:ad_server.cc(80)] OnGetCatalog
[5956:259:0504/110424.522517:VERBOSE1:ad_server.cc(88)] Successfully fetched catalog
[5956:259:0504/110424.522537:VERBOSE1:ad_server.cc(90)] Parsing catalog

Did not encounter https://github.com/brave/brave-browser/issues/22654, my tokens were refilled:

[5956:259:0504/110429.630586:VERBOSE1:refill_unblinded_tokens.cc(322)] Added 50 unblinded tokens, you now have 50 unblinded tokens

Verified user was paid for the NTPSI after upgrade

[5956:259:0504/110620.189347:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id 7450e71c-adc7-4d08-9c2f-79cf1e10c30b and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
..........
[5956:259:0504/110620.192124:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
.........
[5956:259:0504/110620.214614:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 7450e71c-adc7-4d08-9c2f-79cf1e10c30b and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
[5956:259:0504/110620.216291:VERBOSE3:ads_impl.cc(807)] Successfully processed deposit for new_tab_page_ad with creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view valued at 0.01
[5956:259:0504/110620.216350:VERBOSE1:confirmations.cc(60)] Confirming view for new_tab_page_ad with transaction id 25d8cd7b-2088-47ef-af6d-5ac7e856b59f and creative instance id 50fbd528-a0c9-487e-b306-82029e67997f
.........
[5956:259:0504/110631.771016:VERBOSE1:confirmations.cc(296)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id 081e4eaf-1b72-4e9e-b133-08b7d66d006f, transaction id 25d8cd7b-2088-47ef-af6d-5ac7e856b59f, creative instance id 50fbd528-a0c9-487e-b306-82029e67997f and view. You now have 1 unblinded payment tokens which will be redeemed on Friday, May 6, 2022 at 4:05:30 AM

1reaction

btlechowskicommented, May 2, 2022

Added QA/Test-All-Platforms back. When testing please use different locales than previous verifications.