Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

VPN should have a right click to hide

See original GitHub issue

Test plan

On macOS and Windows only (VPN not available on Linux)

Set brave://flags/#brave-vpn to ENABLED
Set brave://flags/#skus-sdk to ENABLED
Restart the browser
Verify the VPN button shows next to Hamburger menu
Right click the VPN button
You should see the menu:
Pick the “Hide VPN button in toolbar” option
VPN button should disappear

Description

If VPN is enabled, some users may not want to see it.

It would be great if they can right click (or ctrl+click) the VPN icon:

And then we can have a context menu show Hide VPN button. This would do the same thing as when you go into settings and using the toggle under appearance:

Issue Analytics

State:
Created 2 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

bscliftoncommented, Mar 12, 2022

Quick update - we won’t be able to test this on Beta until https://github.com/brave/brave-core/pull/12175 is merged (see https://github.com/brave/brave-browser/issues/21598)

0reactions

LaurenWagscommented, Apr 5, 2022

Changing to QA/No per discussion in today’s desktop planning meeting, testing will be covered with https://github.com/brave/brave-browser/issues/15804.