websites not being added into auto-contribution table after contribution as been made
See original GitHub issueDescription
After you’ve contributed, you’ll notice that the attention you’ve spent on the first website you load after the contribution isn’t being calculated correctly. I’ve managed to reproduce this several times and also showed @NejcZdovc via Zoom.
After spending about 20-30s on a website, publisher_info_db
showed three seconds.
Steps to Reproduce
- launch brave using
/Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --rewards-reconcile-interval=4
- once launched, quickly enable rewards via
brave://rewards
- visit several websites and populate the auto-contribution table before four minutes
- ~4 mins, you should see the auto-contribution table clear
- open a new tab and visit a new site for about 30-40s
- switch back to the
chrome://rewards
tab and you won’t see the above entry in the table
If you take a look at publisher_info_db
, you’ll notice that the incorrect time was calculated.
Actual result:
https://drive.google.com/file/d/1OCKmHmQ7G444xWqso33U2aW7xSUiesgX/view?usp=sharing
Expected result:
Websites should be added into the auto-contribution table once they’ve reached the set Minimum page time before logging a visit
Reproduces how often:
100% reproducible using the above STR.
Brave version (brave://version info)
Brave | 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit) |
---|---|
Revision | 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002} |
OS | Mac OS X |
Reproducible on current release:
- Does it reproduce on brave-browser dev/beta builds?
Haven’t tried but assuming this is also in both dev
and beta
.
Additional Information
CCing @jenn-rhim @mandar-brave this is what I was talking about re: websites not being added correctly after a contribution has been made.
Issue Analytics
- State:
- Created 5 years ago
- Comments:6 (6 by maintainers)
Top GitHub Comments
@kjozwiak yeah we are still on that plan
Verified passed with
Verification Passed on