Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

When `Brave Rewards` are disabled, clicking on the link at `brave://settings/rewards` doesn't launch the rewards panel if the `Brave Rewards` button is hidden

See original GitHub issue

Description

If Brave Rewards are disabled, clicking on the link at brave://settings/rewards only begins the rewards processes but wouldn’t launch the rewards panel if the Brave Rewards button is hidden via brave://settings/appearance.

Steps to Reproduce

Make sure Brave Rewards are disabled.
Hide the Brave Rewards button via brave://settings/appearance.
Open brave://settings/rewards.
Click on Click here to learn more.

Actual result:

The Brave Rewards panel wouldn’t show up, as per https://github.com/brave/brave-browser/issues/18158.

Expected result:

Clicking on the link should launch the rewards panel as per https://github.com/brave/brave-browser/issues/18158.

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave	1.33.57 Chromium: 95.0.4638.69 (Official Build) nightly (64-bit)
Revision	6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS	Windows 7 Service Pack 1 (Build 7601)

</body> </html>

Version/Channel Information:

Can you reproduce this issue with the current release? No
Can you reproduce this issue with the beta channel? No
Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? N/A
Does the issue resolve itself when disabling Brave Rewards? N/A
Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@Miyayes @emerick

Issue Analytics

State:
Created 2 years ago
Reactions:1
Comments:7 (4 by maintainers)

Top GitHub Comments

1reaction

Miyayescommented, Jul 25, 2022

@Miyayes Any opinon/thoughts on the correct behavior in this situation (i.e., how do we handle clicking Start Rewards in brave://settings/rewards when the user has the Rewards button hidden)?

Is it possible to temporarily enable it, pop it open, and once Rewards is enabled and onboarding is complete, hide it again?

1reaction

emerickcommented, Nov 3, 2021

@Miyayes Any opinon/thoughts on the correct behavior in this situation (i.e., how do we handle clicking Start Rewards in brave://settings/rewards when the user has the Rewards button hidden)?