question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

(Win/Linux) New Private window should be New private window, in hamburger menu

See original GitHub issue

Implementation note (from @mkarolin; updated by @bsclifton)

  • The _override.grd files can’t be modified; these are auto-generated when we run npm run chromium_rebase_l10n
  • The strings in the _override.grd files are based on automatic generic substitutions that are mapped in https://github.com/brave/brave-core/blob/master/script/lib/grd_string_replacements.py
  • There is no mapping for Incognito -> private
  • One option to solve this is to add a new string into app/brave_generated_resources.grd and then replace IDS_NEW_INCOGNITO_WINDOW with our string ID in code via a chromium_src override.

Original issue description

New Private window should be New private window, in hamburger menu

Windows and Linux desktop only;macOS is taken care of in https://github.com/brave/brave-browser/issues/17308

Steps to Reproduce

  • open the hamburger menu on the browser toolbar
  • look at the capitalization of the menu items

Actual result:

Reads New Private window

windows10-menu

Expected result:

New private window

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.30.3 Chromium: 92.0.4515.131 (Official Build) nightly (64-bit)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS Windows 10 OS Version 2009 (Build 22000.120)

/cc @nullhook

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:18 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
bscliftoncommented, Sep 2, 2021

Thanks for the attempt @SebastianLF - I removed the good first issue tag as there is some complexity here due to the replacement done for Chromium strings by Brave. More information available in https://github.com/brave/brave-core/pull/9821#discussion_r700585827

Updated the top issue with a note

2reactions
stephendonnercommented, Aug 20, 2021

Folks, thanks for your willingness to help; @SebastianLF still has this assigned to him, so I’d like to give him first attempt at solving it; thanks!

Read more comments on GitHub >

github_iconTop Results From Across the Web

New window in private window with tor no longer opens new ...
Steps to Reproduce. Clean install; Open a private window with tor; In private window with tor click New window from Hamburger menu ......
Read more >
How to Activate Incognito Mode for Private Browsing on Linux
Click on the three-dot menu icon located in the top-right corner of the screen. Select New incognito window. chromium private browsing mode.
Read more >
the fact that private windows open like this now ruins the point ...
Close all private windows. Open about:config from the address bar. Look up browser.privateWindowSeparation.enabled and set it to false.
Read more >
How To Browse In Private Mode Using Microsoft Edge ...
Click On The 3 Dot Hamburger Menu In The Upper Right Hand Corner. 3. Select " New InPrivate Window Chapters 0:00 How To...
Read more >
Learn How to Open a New Window or InPrivate ... - YouTube
FREE Course! Click: https://www.teachucomp.com/free Learn how to open a new window or InPrivate window in Microsoft Edge in Windows 11 at ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found