question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Today getCities return just city name, but in Brazil, we have some cities with same name in different states… So I think that we should return stateCode and maybe code (IBGE id) in the returned data.

Something like that:

[
  {
    code: 14324,
    name: 'Bom Jesus',
    stateCode: 'SC',
  },
  {
    code: 14324,
    name: 'Bom Jesus',
    stateCode: 'RS',
  },
  {
    code: 14324,
    name: 'Bom Jesus',
    stateCode: 'RN',
  },
  {
    code: 14324,
    name: 'Bom Jesus',
    stateCode: 'PB',
  },
  {
    code: 14324,
    name: 'Bom Jesus',
    stateCode: 'PI',
  }
]

I know this change will break our API, but since we’re still in RC, maybe it’s not a big problem. What do you think about it @arantespp @andreoav ?

Issue Analytics

  • State:open
  • Created 3 years ago
  • Comments:25 (24 by maintainers)

github_iconTop GitHub Comments

1reaction
arantesppcommented, Dec 7, 2020

I’ll do that and enjoy your vacation 😃

1reaction
arantesppcommented, Dec 7, 2020

Make sense. I’d go for keeping the getCities name.

Read more comments on GitHub >

github_iconTop Results From Across the Web

GET Cities: Home
Gender Equality in Tech (GET) Cities is an initiative designed to accelerate the representation and leadership of women in tech through the development...
Read more >
GETCities on Twitter: ""I know that when we build teams to ...
@GETCities. "I know that when we build teams to solve problems, to design products & systems, that those teams are most effective and...
Read more >
jQuery GetCity is not defined - javascript - Stack Overflow
Your (function GetCity(_warehousesId) {})(jQuery) is wrong. You try to create self-executing function and later you try to use it.
Read more >
Fix For Type '()' cannot conform t… | Apple Developer Forums
So this works ok. my issue is when adding a code above contentView(cities) since it seems this kind of closure only accepts 1...
Read more >
FetchingDataOnDemand Exercise Small Issue - OutSystems
OnChangeCity refresh getCities ... While trying to solve the problem. ... I also fixed the city filter to be what you said first....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found