Breaking changes in 7.5.0

I’m still peeling through all the changes in 7.5.0, trying to understand which of them are breaking.

But as it stands, I haven’t been able to upgrade pg-promise to version 7.5.0 of the driver, with about 35% of all my automated tests failing to even execute correctly.

I may be the first one reporting this, as I’m trying to keep my library up to date at all times, but I won’t be the last one. Expect the same to be reported from people using sequelize, knex, and other frameworks, or anybody else who relies on tests as comprehensive as within pg-promise.

[brianc]

instead of calling client.end try calling client.release(true) - passing a truthy value to release will cause the pool to call .end on the client and evict it from the pool. What you’re likely running into is calling .end on a client and then returning it to the pool…the next time that client is checked out from the pool it’s already ended and wont run queries. I’m not sure how the code was working in the past as calling .end on a client manually and returning it to the pool will eventually fill your pool with ended clients that likely wont ever send their queries. So the change in 7.5 is surfacing an error that was already (I guess somewhat silently) happening.

also, FWIW I don’t think closing a postgres connection in general will cancel a query while it’s running…but I might be wrong there. But, I remember running some extremely long queries from psql in the past and closing psql hoping the query would abort but it didn’t. Foggy memory at this point though.

[brianc]

Glad to know things are settling down! Thanks for the updates. @joelmukuthu LMK if/when you find out what the issue turns out to be.