client.query doesn't call back if connection has been lost

Hi - we’ve come across a scenario where client.query doesn’t invoke the callback as we would expect:

If the connection is initially successful, but later disconnects (for example due to network issues), subsequent calls to client.query just seem to vanish into the ether. We had expected them to invoke the callback with an error object. Is this intended behaviour? If so, is there a workaround?

Having dug into lib/client.js line 307, I wonder if this is related:

Client.prototype._pulseQueryQueue = function() {
  if(this.readyForQuery===true) {
   ...

If the connection isn’t ready for query, nothing seems to happen!

We’re using pg@6.2.2 with node 6.9.1, and AWS Aurora Postgres.

Thanks in advance for any guidance you can give.

[pipmurphy]

Thanks @brianc, that would be perfect - I do think every callback like this needs to be invoked, if only with an error - that’s certainly been my expectation in using this package (which is fantastic, btw) and the callback-with-error pattern generally.

[charmander]

@ccakes The queries are queued with the assumption that you’ll call connect() at some point in the future. I don’t think the query queue on clients is a good part of pg, but that, at least, is intended behaviour.