connection.js line 635 infinite loop

I was using sequelize to connect to my postgres database. However, not paying attention, I didn’t configure the right port and username/password. That made my node.js app loop infinitely on this line. I figured this line out by using node debug .

break in node_modules/pg/lib/connection.js:635
 633 Connection.prototype.parseCString = function(buffer) {
 634   var start = this.offset;
>635   while(buffer[this.offset++] !== 0) { }
 636   return buffer.toString(this.encoding, start, this.offset - 1);
 637 };
debug> o
break in node_modules/pg/lib/connection.js:635
 633 Connection.prototype.parseCString = function(buffer) {
 634   var start = this.offset;
>635   while(buffer[this.offset++] !== 0) { }
 636   return buffer.toString(this.encoding, start, this.offset - 1);
 637 };
debug> o

I don’t experience any other issues If I use correct connection data, so this may be a potential bug, just pointing out this discovery.

[brianc]

I wouldn’t consider it serious troubles. It only causes an issue if you connect the driver to something that isn’t postgres at all and that backend starts sending unexpected binary data back to the driver. Kinda like doing ‘curl’ on to the port postgres is running on: ain’t gonna work. 😯

I will absolutely accept a PR if it fixes bugs or addes enhancements, has tests, and seems reasonable!

[charmander]

This library isn’t built to handle malformed messages at all right now. This case can be fixed by using indexOf instead of a manual loop, but the built-in message parsers in general don’t attempt to detect errors. @brianc, would you be interested in changes to that end?