pg.end() doesn't always end the connections

Simple testcase:

var opts = {
    "driver": "postgres",
    "host": "localhost",
    "user": "nodetest",
    "password": "password",
    "database": "nodetest"
}


var pg = require('pg');

pg.connect(opts, function(err, client) {
    pg.end();
});

Then executing it:

% time node test_pg.js
^Cnode test_pg.js  2.49s user 0.66s system 0% cpu 14:10.42 total

I halted the program after 14 minutes. If I modify it like this:

var opts = {
    "driver": "postgres",
    "host": "localhost",
    "user": "nodetest",
    "password": "password",
    "database": "nodetest"
}


var pg = require('pg');

pg.connect(opts, function(err, client) {
    client.query('select * from person', function(){
        pg.end();
    });
});

Then it works:

% time node test_pg.js
node test_pg.js  0.12s user 0.02s system 11% cpu 1.142 total

[fsateler]

Ehm… According to the docs, calling pg.end will kill any connection (not cleanly). It specifically says it is intended for unit tests. I came across this bug because my unit tests were not ending even when I called pg.end().

[brianc]

pg.end should work correctly now

I’ve changed the pool substantially to no longer rely on the drain event at all. No pauseDrain no resumeDrain. Documentation is a work in progress.

https://github.com/brianc/node-postgres/wiki/pg https://github.com/brianc/node-postgres/pull/274