useDefaultRoute is not working from v6.7.0

https://github.com/brightcove/hot-shots/compare/v6.6.0...v6.7.0

Seems like the createTransport is taking the host parameter before it is updated by the useDefaultRoute. That means, from v6.7.0, if the hot-shots is running inside a docker container, it will still send the metrics to localhost by default, instead of sending to the actual host ip 172.17.0.1.

We shall consider move the code of line 146~152 to before line 43, which is where the host is being used for createTransport.

https://github.com/brightcove/hot-shots/blob/master/lib/statsd.js#L146-L152

[bdeitte]

This one fixed in 6.8.2

[Gobie]

I would respectfully disagree

const dns = require('dns')
dns.lookup('google.com', console.log.bind(console, 'lookup callback'))
console.log('call after lookup')

➜ node test.js
call after lookup
lookup callback null 216.58.201.110 4