Cloudflare with esbuild broken with v0.3.56

Hi,

Since the latest version I get the following warning when trying to build with esbuild:

▲ [WARNING] Import “createPageRenderer” will always be undefined because the file “…/…/node_modules/vite-plugin-ssr/dist/esm/client/node.js” has no exports

worker/index.ts:1:9:
  1 │ import { createPageRenderer } from 'vite-plugin-ssr'
    ╵          ~~~~~~~~~~~~~~~~~~

When I ignore this warning, miniflare throws this error at me:

MiniflareCoreError [ERR_MOUNT]: Error mounting “project” […] { code: ‘ERR_MOUNT’, cause: Error: [vite-plugin-ssr@0.3.56][Wrong Usage] The module vite-plugin-ssr cannot be imported in the browser. Did you mean to import the module vite-plugin-ssr/client instead? at …/…/node_modules/vite-plugin-ssr/dist/esm/client/node.js (/…/dist/worker.js:197:5) at __init (/…dist/worker.js:9:56) at /…/dist/worker.js:47083:1

My `build.js` file which builds the worker

import esbuild from 'esbuild'
import { NodeModulesPolyfillPlugin } from '@esbuild-plugins/node-modules-polyfill'

esbuild
  .build({
    external: ['__STATIC_CONTENT_MANIFEST'],
    entryPoints: ['./worker/index.ts'],
    sourcemap: false,
    outfile: './dist/worker.js',
    logLevel: 'info',
    platform: 'browser',
    plugins: [NodeModulesPolyfillPlugin()],
    format: 'esm',
    target: 'es2020',
    bundle: true,
  })
  .then(() => console.log(`Successfully built worker.`))

[brillout]

Try this:

The main problem is that esbuild resolves the wrong value of package.json#exports. But I’m just seeing the conditions config; that should do the trick.

From https://github.com/evanw/esbuild/issues/1189.

[dan-lee]

@brillout Great suggestion! I’ve just opened a PR for this