question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Port ember-cli/broccoli-builder to master

See original GitHub issue

I am going to attempt to summarize the work that needs to be done to port the changes made to https://github.com/ember-cli/broccoli-builder into broccoli, so that the fork can be retired and ember-cli can use broccoli master

Glossary:

Diff:

I created a patch from branch-point-with-tests to 0-18-x https://github.com/oligriffiths/broccoli-builder/pull/7 that shows the changes basically from the whole 0-18-x series so we can see what has actually changed (minus file deletions and the conversion of the test suite from tap to mocha).

Todo:

Bonus points

  • Mid-build change events should cancel the current build and queue up behind the existing cancel before kicking off another build. This allows for if a watched file changing mid build, to cancel the current build and kick off a new one. This is out of scope for upstreaming to master. https://github.com/broccolijs/broccoli/pull/350

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:18
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
oligriffithscommented, Nov 29, 2018

Yup

1reaction
oligriffithscommented, Jun 11, 2018

@stefanpenner I think we should do that as a separate step as it’s not directly part of Broccoli-builder and the intention here is to remove the builder.

Read more comments on GitHub >

github_iconTop Results From Across the Web

EBF Delegated Admin
# Module Name Licence Type 1 @babel/code‑frame@7.0.0 MIT 2 @babel/code‑frame@7.0.0‑beta.40 MIT 3 @babel/core@7.3.4 MIT
Read more >
ember-cli - Bountysource
For an Ember app, ember-cli-build.js receives an argument defaults , which it is expected to pass into the EmberApp constructor, along with another...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found