Port ember-cli/broccoli-builder to master
See original GitHub issueI am going to attempt to summarize the work that needs to be done to port the changes made to https://github.com/ember-cli/broccoli-builder into broccoli, so that the fork can be retired and ember-cli
can use broccoli master
Glossary:
master
refers to https://github.com/broccolijs/broccoli/tree/master0-18-x
refers to https://github.com/ember-cli/broccoli-builder/tree/0-18-x- Branch point: The commit
ab404ef725be5c265c901838be40d0358a867ec4
that ember-cli/broccoli-builder branched from broccoli master - Branch point + tests: The commit just after branch point,
f5a1f3ddb1a01a4a9c312be12f1efed2b6d38611
that the test suite was converted from tap to mocha and exists inmaster
but not0-18-x
Diff:
I created a patch from branch-point-with-tests
to 0-18-x
https://github.com/oligriffiths/broccoli-builder/pull/7 that shows the changes basically from the whole 0-18-x series so we can see what has actually changed (minus file deletions and the conversion of the test suite from tap to mocha).
Todo:
- On
0-18-x
, port test suite to mocha frombranch point + tests
, as this happened just after the branch point, so to make comparisons easier I have ported the test suite to use mocha - On
master
, add the ability to overwrite adist
directory without having to remove the directory first https://github.com/broccolijs/broccoli/pull/354 - On
master
, port the protection of thedist
directory from-0-18-x
if it’s a direct parent of the project https://github.com/broccolijs/broccoli/pull/358 - On
0-18x
deprecateapi_compat.js
. This was to support the old read API, and is no longer supported in Broccoli and hasn’t been used in ember for some time. Start with a console warning, then remove. https://github.com/oligriffiths/broccoli-builder/blob/diff/lib/api_compat.js https://github.com/ember-cli/broccoli-builder/pull/26 - On
0-18x
killapi_compat.js
. - On
master
, portheimdall
stats collection from0-18-x
Investigate the event api in Broccoli for this instead of hand jamming: https://github.com/broccolijs/broccoli/pull/362 - On
master
, portcancellation
from0-18-x
https://github.com/broccolijs/broccoli/pull/350 - On
master
portbroccoli-build-error
from0-18-x
https://github.com/oligriffiths/broccoli-builder/blob/diff/lib/broccoli-build-error.js this is a nicer error output that only shows the stack trace for where the error happened within a Broccoli plugin - On
master
validate the ability to have thetmp
directory in the project root (per ember-cli) for compat with addons that have used this hack https://github.com/ember-cli/ember-cli/pull/7798
Bonus points
- Mid-build change events should cancel the current build and queue up behind the existing cancel before kicking off another build. This allows for if a watched file changing mid build, to cancel the current build and kick off a new one. This is out of scope for upstreaming to master. https://github.com/broccolijs/broccoli/pull/350
Issue Analytics
- State:
- Created 5 years ago
- Reactions:18
- Comments:6 (6 by maintainers)
Top Results From Across the Web
EBF Delegated Admin
# Module Name Licence Type
1 @babel/code‑frame@7.0.0 MIT
2 @babel/code‑frame@7.0.0‑beta.40 MIT
3 @babel/core@7.3.4 MIT
Read more >ember-cli - Bountysource
For an Ember app, ember-cli-build.js receives an argument defaults , which it is expected to pass into the EmberApp constructor, along with another...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Yup
@stefanpenner I think we should do that as a separate step as it’s not directly part of Broccoli-builder and the intention here is to remove the builder.