Omnibar history (fixed in v1.0.5)/bookmark (NOT fixed) search doesn't like spaces anymore (v1.x)
See original GitHub issueUpdate 2022-03-18; b
issue
Surfingkeys 1.0.5.
The issue for oh
, t
and T
was fixed in v1.0.5; but as @nbaudis
mentioned below that the b
(Open a bookmark) command still suffer from
the same issue described in the original report down below.
Searching in Omnibar, specially for history and bookmarks, is very
important as it’s the front-end of a user data; I hope, again as it
fixed for other commands, to be fixed for the b
command. Thank you!
Original report (2022-01-07); fixed in v1.0.5
Title (was): Omnibar history search doesn’t like spaces anymore (v1.x)
Hello,
Surfingkeys 1.0.2.
Suppose you visited these links:
https://github.com/foo/bar
https://www.youtube.com/user/bar
https://gitlab.com/foo/bar
https://github.com/baz/qux
Invoking oh
(Open URL from history) command then typing
gith<space>bar
:
- Prior to v1.x:
- This will show
https://github.com/foo/bar
as the result of the search.
- This will show
- v1.x:
- Nothing will shows up the moment you hit the space key as mentioned in the search term above.
The idea of using “gith” is to filter all history first then applying
another filter to the desired web page. This way I don’t get results
from GitLab if I wanted https://github.com/foo/bar
page. Searching
with the term “bar” alone will show a lot of false positive results, but
typing a prefix, part of website’s name, <space>
then a term is much
better to get few hits. Another example is to type yo<space>bar
to get
history results for “bar” in YouTube website.
I noticed that t
(Open a URL) and T
(Choose a tab) commands are
working fine with the search term I mentioned, so the issue is only in
oh
Omnibar.
I hope you can fix this as I’m relaying on this type of search and filter a lot. Thank you!
Issue Analytics
- State:
- Created 2 years ago
- Reactions:2
- Comments:9 (1 by maintainers)
Top GitHub Comments
Seems that v1.0.5 works well?
@nbaudis
I discovered that using
t
(Open URL) command can search bookmarks without issues in re. to what mention in OP.Still, the list is clutter with other type of URLs.
My test was on latest 40a37ec that I built from upstream.
Hope this helps.