Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

feature_request(browsers): different messages for browsers

See original GitHub issue

#325 — related issue.

1. Summary

It would be nice, if would be possible use different messages for different browsers.

2. Argumentation

I don’t want support any Internet Explorer version on my sites, arguments — 1, 2.

Also, I don’t support outdated versions of another browsers.

I need use different messages — browser unsupported and browser outdated, — but I can’t find, how I can do it, use browser-update.

3. Example

Messages:

If Internet Explorer:

Similar as in @josselex comment — Internet Explorer is not supported on this page, we recommend you to use an additional other browser for the best experience on this page.

else outdated version of another browser:

Similar as default message — Your web browser {brow_name} is out of date. Update your browser for more security, speed and best experience on this site

Thanks.

Issue Analytics

State:
Created 5 years ago
Comments:8 (3 by maintainers)

Top GitHub Comments

1reaction

Kristinitacommented, Feb 18, 2019

@josselex, ping. Examples:

For Opera Mini users it would be nice to show content from this and this links
For Internet Explorer users — this and this

Thanks.

0reactions

Kristinitacommented, Sep 16, 2020

@josselex,

Status: Implemented with problem 🌔

1. Testing

1.1. Environment

BrowserStack — free plan for open source.

1.2. Script

$buoop =
    required:
        f: 4147
        i: 4147
        uc: 4147
        ios: 4147
        c: -2
        o: 4147
    reminder: 0
    api: 2020.09
    text: 'Kira Goddess! Test 1 — Any outdated browser'
    text_for_i: 'Kira Goddess! Test 2 — Internet Explorer'
    text_for_uc: 'Kira Goddess! Test 3 — UC Browser'
    text_for_ios: 'Kira Goddess! Test 4 — iOS'
    text_in_ru: 'Кира Богиня! Test 5 — Russian language'
    text_for_c: 'Kira Goddess! Test 6 — Chrome'
    text_for_o_in_ru: 'Кира Богиня! Test 7 — Edge in Russian'

$buo_f = ->
    e = document.createElement('script')
    e.src = 'https://browser-update.org/update.min.js'
    document.body.appendChild e
    return

try
    document.addEventListener 'DOMContentLoaded', $buo_f, false
catch e
    window.attachEvent 'onload', $buo_f

Also, I increased font size, because on mobile devices browser-update message too small:

div.buorg
    font-size 2rem

2. Priority problem

During testing, I found that, in my opinion, currently, browser-update haven’t the best priority for text options.

2.1. Data

For example, we have 3 options for Edge:

text_in_ru
text_for_e_in_ru
text_for_e

2.2. Desired behavior

text_for_e_in_ru — this is the most specific setting, it must have high priority. That is, the text_for_e_in_ru value must be displayed, even we have text_for_e and/or text_in_ru.
Further, in my opinion, should be text_for_e. text_in_ru — common option for any browsers on Russian; text_for_e — specifically for Edge. But good web developer must add text_for_e_in_ru, if he already has text_for_e and text_in_ru.
text_in_ru — the lowest priority of three.