Bug introduced in 12.0.1 (Breakage with symlink + Babelify)

Overview

The single line (excluding tests) changed in patch release 12.0.1 causes breakage in applications using symlinks and Babelify.

(I discovered this today, as the latest release of grunt-browserify upgrades Browserify from v11 to v13.)

Specifics

I have a project which uses symlinks in accordance with the Browserify Handbook, arranged as follows:

node_modules/
├── ...
└── appName   -- symlink to 'src/' directory

src/
├── ...
└── main.js

...

.babelrc      -- where Babelify looks for its parameters
...

I then simply execute (the Grunt equivalent of):

browserify src/main.js -o build/app-name.js -s AppName -t babelify

This works perfectly through Browserify 12.0.0, but as of 12.0.1 and beyond, I see the error:

ParseError: 'import' and 'export' may appear only with 'sourceType: module'

This error does not occur (and the build succeeds) if I don’t use the symlink in my imports.

As implied above, everything works as it used to if I simply revert the offending line in index.js: cb(err, res, pkg, file); → cb(err, res, pkg);

[rkirsling]

After eventually discovering #993, it appears that this may never have been intended to work, in spite of what the documentation suggests. In fact, when someone was kind enough to propose an update to the documentation (substack/browserify-handbook#36, 15 months ago), he was simply ignored.

I have confirmed that adding a src/package.json solves the issue:

{ "browserify": { "transform": ["babelify"] } }

Perhaps not a satisfying solution, but a solution nonetheless.

Really, I’m just in disbelief at the total lack of attention and documentation that this problem has received.

[BlueRaja]

Is anyone looking into this? Seems like a pretty simple fix for a pretty horrendous bug.