Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

shakes out functions that I used

See original GitHub issue

I’m not sure if this plugin in production ready yet, but it seems that it removed functions that I’m definitely using.

Using import to get the modules, but running babel as a browserify transform, so that should rewrite everything to require.

seems that most of the incorrectly removed functions are from the crypto-browserify package.

Issue Analytics

State:
Created 6 years ago
Comments:6 (2 by maintainers)

Top GitHub Comments

1reaction

retail-robotcommented, Apr 20, 2018

Hi - I’m running into this issue too - I threw together a project that reproduces the issue here: https://github.com/retail-robot/common-shakeify-issue-12-repro

You should be able to clone it and just npm install + npm run build

0reactions

toddselfcommented, Apr 26, 2018

hi! we just ran into this too with the sbd library.

it is stripping out /lib/Match.js:isCaptialized, even though that function is called via this within the code.

09:42:00 ~/src/sbd:master
↳ npx browserify -p common-shakeify lib/tokenizer.js > shake.js
09:42:07 ~/src/sbd:master
↳ npx browserify lib/tokenizer.js > no-shake.js
09:45:03 ~/src/sbd:master
↳ grep isCapitalized shake.js
/* common-shake removed: exports.isCapitalized = */ void function(str) {
    return this.isCapitalized(str) || /``|"|'/.test(str.substring(0,2));
    return this.isCapitalized(str);
        if (wordCount < 5 && words[0].length < 6 && this.isCapitalized(words[0])) {