Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

GitHub Design & Repository Refresh

See original GitHub issue

Github has a new Design and Repository Refresh in feature preview. To support it, making the following change works:

https://github.com/brumm/tako/blob/e981f7845960def9fd6ead2870518742be32bd65/src/constants.js#L1

-  export const MOUNT_SELECTOR = 'table.files'
+  export const MOUNT_SELECTOR = '.Details [role="grid"]'

It seems like GitHub has done away with the table and now uses plain divs. Unfortunately, there isn’t a clear selector that we can use to target the files list, and I’m not sure how reliable the solution above is. Possibly, aria-labelledby="files" can also be used or a selector with .parentElement, but this needs to be investigated.

Also, the design refresh has updated the icons, so those will have to be updated as well.

Refresh	Refresh + Tako

Issue Analytics

State:
Created 3 years ago
Comments:8 (5 by maintainers)

Top GitHub Comments

2reactions

brummcommented, Jun 23, 2020

Oh neat, I’ll check and push out the release soon. Thanks for checking!

Philipp Brumm - Chat @ Spike [kdo99]

1reaction

brummcommented, Sep 20, 2020

Finally found some time to look at this, and just submitted new versions to both the Firefox and Chrome extensions stores. Should update in 24hrs-ish. Let me know if anything breaks!