Brunch global require conflicts with node local require

Description

The bundle generated by brunch is not compatible with node’s environment, whenever I try to run the bundle in node for server rendering, I get something like:

TypeError: require.register is not a function

It is trying to use node’s require, and not brunch’s.

Since in node require is in the local context, so it takes precedence over brunch’s require, which is places in the global context.

Proposed solution

I think we could rename require to __require__ in commonjs-require-definition/require.js and within the bundle.

We could still export both __require__ and require to the global context.

Or we could remove commonjs-require-definition/require.js from its own scope, so at least inside the bundle it overrides node’s require (but this seems nasty).

I’m not sure if there is a better solution 😃

Environment

1. Brunch: 2.8.2
2. Node: v6.2.0
3. NPM: 3.8.9
4. Operating system: OS X El Capitan 10.11.6

[etwark]

@overallduka Great idea. I’ll give it a try and see what I come up with. Thanks!

[reubano]

@paulmedynski I think you miss-understood what @paulmillr is saying. Anyone can create a pull request (PR), you don’t have to be a maintainer. Once you successful create a PR, he will then be open to giving you commit access. Many projects operate this way to limit maintainer rights to those who have actually contributed to the project.