Filtering for "paid invoices" produces no results

Describe the bug

The Paid invoices filter doesn’t work anymore. All other invoice filters still work as expected (Invalid, Paid Late, Paid Partial, Paid Over, Unusual, Archived).

This worked in all versions up to 1.3.7 and broke in 1.4.0.

When filtering for “paid”, the filter query will change to status:processing,status:settled as defined here: https://github.com/btcpayserver/btcpayserver/blob/f3592c4782f160a597f845ae5a023bede846e148/BTCPayServer/Views/UIInvoice/ListInvoices.cshtml#L284

Either this code is wrong or the documentation/explanation is, as per here: https://github.com/btcpayserver/btcpayserver/blob/f3592c4782f160a597f845ae5a023bede846e148/BTCPayServer/Views/UIInvoice/ListInvoices.cshtml#L259

My current workaround is to manually enter status:complete which will show all paid (settled) invoices.

To Reproduce the bug Steps to reproduce the reported bug:

1. Go to ‘invoices’
2. Click on ‘Paid invoices’, via the drop-down menu on the right side of the search button
3. Observe an empty list

Expected behavior

I would expect paid invoices to show up, as they did in previous versions.

Screenshots

(I removed the storeId when taking the screenshots above, but it doesn’t matter)

Your BTCPay Environment (please complete the following information):

• BTCPay Server Version: v1.4.3.0
• Deployment Method: Docker
• Browser: Firefox

[dennisreimann]

The state shown in the list is the new label and it looks like the filter is still applied based on the old status labels. I can reproduce it and filter the invoices using the old labels:

• paid (old) -> processing (new)
• completed (old) -> settled (new)
• confirmed (old) -> settled (new)

Fixing this now.

[NicolasDorier]

use status:paid,status:confirmed,status:complete,status:settled,status:processing instead. This is fixed in next release.