question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[feature]: Specify failurepolicy when MutatingWebhookConfiguration is created

See original GitHub issue

Is your feature request related to a problem? Please describe.

I’m trying to create a mutator on a pod, which works only while my operator is running. When the operator dies, for example, restarting the deployment, the pods can’t be created because the failurePolicy is set to Fail, the default. When the pod starts up after changing it manually it gets reset to Fail.

Describe the solution you would like

Have a method called on the webhook that will allow us to configure the webhook and other objects that get installed in the cluster.

Additional Context

No response

Issue Analytics

  • State:closed
  • Created 7 months ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
edwardcookemacucommented, Feb 25, 2023

A pull request is created. It also addresses #525, something that was also causing me pains. I implemented that as an opt-in feature since it would delete the existing webhooks and recreate them on startup to guarantee an expected state.

0reactions
EdwardCookecommented, Feb 24, 2023

Awesome. I’ll try and get a PR up in the next couple of days. I was thinking of a new interface that could optionally be implemented that would be called. Should be pretty easy to follow.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Dynamic Admission Control
failurePolicy defines how unrecognized errors and timeout errors from the admission webhook are handled. Allowed values are Ignore or Fail .
Read more >
Diving into Kubernetes MutatingAdmissionWebhook
MutatingWebhookConfiguration specifies which webhook admission servers are enabled and which resources are subject to the admission server. It ...
Read more >
kubernetes.admissionregistration.k8s.io.v1. ...
FailurePolicy defines how unrecognized errors from the admission endpoint are handled - allowed values are Ignore or Fail. Defaults to Fail. matchConditions ...
Read more >
webhooks - OpenShift Documentation
FailurePolicy defines how unrecognized errors from the admission endpoint are handled - allowed values are Ignore or Fail. Defaults to Ignore. name. string....
Read more >
mutating-webhook/README.md at master
The Admission Controller calls mutating webhooks while in the mutating phase. Mutating Webhooks can modify the incoming objects. Mutating Webhooks can do it...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found