question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add BuildTarget.baseDirectory: Uri

See original GitHub issue

Following up from discussions in #30

Currently, there is no way to associate a BuildTarget with a single directory. This information is needed by some IDEs like IntelliJ in order to group together related targets such as main and test.

Based on discussions in #30, we should add a new field to the BuildTarget data structure

trait BuildTarget {
+ /** The directory where this target belongs to. Multiple build targets are allowed to map
+  * to the same base directory. A base directory does not determine the sources 
+  * of a target, see buildTarget/sources.
+ def baseDirectory: Uri
}

At the moment, the IntelliJ Scala plugin infers the base directory from BuildTargetIdentifier.uri path ignoring the URI fragment/query-parameters. Build target URIs are supposed to be opaque IDs, which the build tool is free to encode in any way it likes.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:21 (21 by maintainers)

github_iconTop GitHub Comments

1reaction
jvicancommented, Oct 29, 2018

I’m fine with moving forward with the current proposal. Let’s try to get the BSP v2.0 release out soon 😺

1reaction
jvicancommented, Oct 26, 2018

Fine, but I’m not comfortable with the current inconsistency in the protocol. If you want to add baseDirectory: Uri to BuildTarget, I propose you change TextDocumentIdentifier to TextDocument and only leave the suffix Identifier for something that is required to be unique, but that requires no assumptions on the client side. Otherwise, we should keep it as is.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Add BuildTarget.baseDirectory: Uri · Issue #50 · build-server ...
The problem at hand seems to beg for a solution. I then suggest we should add a field def name: String to BuildTarget...
Read more >
Overview - Build Server Protocol
Build Target Identifier. A unique identifier for a target, can use any URI-compatible encoding as long as it is unique within the workspace....
Read more >
Configuration Properties - IBM
All build configuration properties support the standard property attributes, but most attributes are ignored as the values for the attributes are set internally ......
Read more >
Using Ant to build dependencies of the current build target
A build invoked via the <ant> task this way by default inherits all properties from the caller, including basedir , hence the build...
Read more >
Scripting API: BuildTarget - Unity - Manual
They may be set by us or by third party providers whose services we have added to our pages. If you do not...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found