question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

support `Link` from react-router-dom (button-close not rendered anymore when using custom children)

See original GitHub issue

currently using custom children so that I can bind Link from react-router-dom to the links, would there be a better way to make it work?

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
dinuchiriaccommented, Aug 8, 2017

In my case i want to have a custom link to /privacy page in the banner and a separate close button

The issue is that close button <div className="button-close">Got it</div> is not working anymore if using custom html.

0reactions
FrancescoCioriacommented, Apr 13, 2018

I opened a PR to fix this issue: #52

Read more comments on GitHub >

github_iconTop Results From Across the Web

Forcing a React-Router <Link> to load a page, even if we're ...
I solved this by pushing a new route into history, then replacing that route with the current route (or the ...
Read more >
Migrating to React Router v6: A complete guide
Migrate your React Router applications from v5 to v6 with this in-depth guide, including a review of additions and improvements from v5.
Read more >
Upgrading from v5 v6.6.1 - React Router
For example, a <Link to="me"> that is rendered inside a <Route path="users"> will always render a link to /users/me , regardless of whether...
Read more >
Suspense for Data Fetching (Experimental) - React
Approach 1: Fetch-on-Render (not using Suspense). A common way to fetch data in React apps today is to use an effect: // In...
Read more >
How to handle navigation in your app with React Router Link
In this article, we'll explore the navigation possibilities in a React app and we'll take a look at the React Router Link component....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found