Bad practice with generate_one_time_code

Not so long ago, I came across the fact that with two-factor authentication comes empty response (#53). It turned out that if you authorize the client several times without restarting application, the same one-time code will be generated. It’s a bad idea to pass a variable like time.time() to the default value:

def generate_one_time_code(shared_secret: str, timestamp: int = int(time.time())) -> str:
    # generating one-time code

Probably, it should look like this:

def generate_one_time_code(shared_secret: str, timestamp: int = 0) -> str:
    if not timestamp:
        timestamp = int(time.time())
    # generating one-time code

[bukson]

Already on master, much much thanks!

[timwoocker]

You saved my life! I’m currently creating a service with multiple steam bots. A bot is getting logged in as soon as a user requests it but since the app could already be running for some minutes or hours, the login fails with the error “Invalid Credentials”. I think this bug is also caused by the generate_one_time_code method.