Line Highlighting on Code Fences

I like to add line highlights to my code fences using the syntax described here.

This breaks the highlighter with language-markdown. I’ve solved it by replacing the code fence “begin” regex in grammars/language-markdown.json. e.g. for JavaScript:

         {
-         "begin": "^\\s*([`~]{3,})\\s*(\\{?)((?:\\.?)(?:javascript|js|jsx))(?=( |$))\\s*([^`\\}]*)(\\}?)$",
+         "begin": "^\\s*([`~]{3,})\\s*(\\{?)((?:\\.?)(?:javascript|js|jsx)(?:\\{[0-9,\\-\\s]*\\})?)(?=( |$))\\s*([^`\\}]*)(\\}?)$",
          "beginCaptures": {
            "1": {
              "name": "punctuation.md"
            },
            "2": {
              "name": "punctuation.md"
            },
            "3": {
              "name": "language.constant.md"
            },
            "5": {
              "patterns": [
                {
                  "include": "#special-attribute-elements"
                }
              ]
            },
            "6": {
              "name": "punctuation.md"
            }
          },

Is this the best way to handle this? If so, I can submit a PR with these regexes if you have any interest in supporting this line highlights syntax. It’s not really part of any markdown standard, and I’m not sure how widespread this practice is, so I understand if it’s more trouble than it’s worth!

[burodepeper]

@eloquently See the commit above. This fixes your issue, but I’ve chosen not to apply any scopes to the line-numbers per se. I think it’s rather premature and as of yet unnecessary to make a decision in that area. I’m still working on a few other changes in the dev branch, but expect this change to be part of the next update to the package. I’m marking this as closed, because I think this solution is at least good enough.

[burodepeper]

@zpao Thanks for your input!

I think your last remark about allowing anything in the info-string is what I’m probably going for. I saw some interesting ideas about the {key=value} attribute syntax on talk.commonmark.org (wasn’t aware of that, thanks) too.