Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
defaultTableHeaderRenderer should include the container
See original GitHub issueI’ve been trying to reorder table columns with react-sortable-hoc. This is what I came up with, it almost works well, but I have to drag the headers pretty far in order for them to swap places.
It turns out that this happens because the defaultTableHeaderRenderer actually returns an array of children, without the container, so I have to add the container myself. However, this means that column header decorated with sortableElement won’t be a direct child of the header row decorated with sortableContainer, and that seems to be what causes the problem.
My proposition is to adjust defaultTableHeaderRenderer to also include the container, rather than only children. This may fix future issues with integrating with other library, not only react-sortable-hoc.
Issue Analytics
- State:
- Created 6 years ago
- Comments:10 (10 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
You’ve probably already seen this but @clauderic added a demo of this with source code.
Thanks for being willing to review it. In the meantime I realized that I’m not very smart 😆 and that the existing API provides enough flexibility.
headerRowRendererrenderer allows me to make sortable header cells direct descendants of the their sortable container (the header row) via thecolumnsparam. Thanks for providing a flexible API! ❤️If anyone reading this would like to see an example, I’ll post it soon to react-sortable-hoc#218.