question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Version 10 breaking changes

See original GitHub issue

This issue doesn’t imply that version 10 will be released any time soon. I just want a place to list some ideas so I won’t forget them.

  • Remove AutoSizer in favor of react-measure (based on the Resize Observer spec, can be polyfilled). This seems like a more future-friendly way of detecting resize.
  • Remove individual Table row-level event handler props in favor of an object (eg rowEventHandlers) that gets spread on each row. This will enable more flexible event event handling without requiring rowRenderer to be override while avoiding unsupported props warnings.
  • Maybe split some of the HOCs (eg WindowScroller, InfiniteLoader) out into their own packages to reduce the clutter and bundle size for people wanting only windowing components? (This was suggested to me by a lib user. I haven’t put much thought into it. Would probably also need to go hand-in-hand with using something like Lerna.)
  • Consider refactoring InfiniteLoader to be less row-centric (see #973)

Issue Analytics

  • State:open
  • Created 6 years ago
  • Reactions:29
  • Comments:16 (6 by maintainers)

github_iconTop GitHub Comments

5reactions
souporseriouscommented, Jun 21, 2017

Just came across this. Was going to file an issue to see if you wanted to consider a ResizeObserver 😆 I’d be willing to help try and push this through. I would suggest using the polyfill direct. It’s a pretty small amount of code to get it setup. As far as measuring goes, we can attach the observer to the parent node if we need to.

5reactions
avocadowastakencommented, May 4, 2017

Currently I’m using only Table component (didn’t have a chance to use other components) and got lot of custom editable columns like checkboxes, inputs and selects.

To make them reusable i’m using factories like that:

const createCheckboxColumn = props => (
  <Column
    width={56}
    minWidth={56}
    label={props.label}
    dataKey={props.dataKey}
    disableSort={true}
    style={{ minWidth: `${56}px` }}
    headerClassName={cx(props.headerClassName, classes.checkboxColumn)}
    headerRenderer={() => (
      <Checkbox
        disabled={!props.rowCount}
        value={props.allRowsSelected}
        onChange={value => props.onAllRowsSelect(value)}
      />
    )}
    className={cx(props.className, classes.checkboxColumn)}
    cellDataGetter={row => row.rowData}
    cellRenderer={row => (
      <Checkbox
        value={props.rowSelected(row)}
        onChange={selected => props.onRowSelect({ selected, ...row })}
      />
    )}
  />
);

const table = (
  <Table {...props}>
    {createCheckboxColumn(checkboxProps)}
  </Table>
);

Not sure if it’s even a good idea in case of perf, but It would be great to have an option to make it work in “react way”:

const table = (
  <Table {...props}>
    <CheckboxColumn {...checkboxProps} />
  </Table>
);
Read more comments on GitHub >

github_iconTop Results From Across the Web

Breaking changes from V10 -> V16 ? #42622 - GitHub
There are many breaking changes between Node.js 10 to 16. To find them in the changelog, you'd need to review the semver major...
Read more >
breaking changes - Angular 10
No information is available for this page.
Read more >
NodeJS 10: The New, The Changed, and the Deprecated
Node.js 10 comes packed with significant performance improvements through V8 v6.6 and new experimental features such the fs promise API and ...
Read more >
Apache Tomcat® - Migration Guide - Tomcat 10.0.x
There is a significant breaking change between Tomcat 9.0.x and Tomcat 10.0.x. ... When upgrading instances of Apache Tomcat from one version of...
Read more >
Updating to Angular version 10
Updating CLI Apps · Changes and Deprecations in Version 10 · New Breaking ... This guide contains information related to updating to version...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found