question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Re-creating the entire body/row nodes on data change

See original GitHub issue

I’m having an issue caused by this component re-creating the entire body when the data changes even though the scroll position is the same. I would think given this condition, React’s reconciliation algorithm would skip over the FixedSizeList Body/rows and just append the innerHtml of the cell with the new value (This would be the ideal for my useCase, but maybe not for everyones). If I generated a list by mapping over rows, if the data changed react would append the changes to the cell without destroying/re-creating everything.

I wonder if something could be done about this, I could even take a look at your src, but diving in would take some time to understand the internal flow.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:1
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
DDinennocommented, Aug 13, 2019

Yep that did it.

I actually was memoizing the rows in my actual implementation, but I guess improperly since I was using Inline functions and not using the itemData( I didn’t think it was necessary at the time).

Great history lesson on inline-functions. I’m gonna stay away from those as much as possible.

Thanks a bunch! you don’t know how much this helped me out and sorry for wasting your time, it was mostly ignorance on my part. I took a look at your future changes and I’m hyped to see them in action. Good luck with everything, this is such a helpful plugin for react ecosystem!

0reactions
brunolemoscommented, Aug 27, 2019

I actually was memoizing the rows in my actual implementation, but I guess improperly since I was using Inline functions and not using the itemData( I didn’t think it was necessary at the time).

I just found out I did the exactly same thing, that’s why all list items were re-rendering even if only a single item changed. Thanks for pointing it out! 🙌

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to insert text in body row ? | SAP Community
1)If all the data,u need to display in 2 or 3 rows, exist in same ... you can try to change the generated...
Read more >
lib/Data/Edit/Xml.pm - metacpan.org
add*asTree # change wrap and other commands that use %attributes rather than ... my $s = string($x); # Parse tree as string new($s);...
Read more >
Untitled - Login
This situation has now changed as all browsers are free. Computer users can today choose which browser they want to use. On tablets,...
Read more >
Using Designer - Adobe Support
You can filter the nodes to work with and quickly create a form using some or all of the data source. You then...
Read more >
Eric's Archived Thoughts - meyerweb.com
(I may go back and replace all the superscript elements with styled <mark> ... One of the bigger challenges of recreating The Effects...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found