Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Question]: Payload size limit?

See original GitHub issue

First of all, great project and great work!

Now the question, of curiosity, if the payload (e.g., bundled script) size is greater than 0xFFFFFFFF bytes, would bytenode still work? I’m asking because kPayloadLengthOffset is just uint32.

Thank you.

Issue Analytics

State:
Created a year ago
Reactions:1
Comments:6

Top GitHub Comments

1reaction

OsamaAbbascommented, Apr 8, 2022

This question crossed my mind before. I don’t believe this limitation applies exclusively with bytenode, because the same logic and limitation still will be used with any script that v8 deals with (i.e. all javascript files). I think I tried before to generate a huge javascript file and run it with and without bytenode, but I don’t remember the results though 😃 . I might try the same experiment again and get back to this issue.

Thanks for your interest and your kind words.

0reactions

overflowzcommented, Apr 8, 2022

Thank you for the research! Yeah, the performance is just too much haha, guess it does not need to produce bytecodes (including optimizations, etc) anymore and that could be the thing ;p

EDIT: Thank you, this is very useful!