can not remove rule

Hello,I’m looking for a rule engine written in js,and I find this project easy to use,and following is my problem using the engine. I add a rule,then run the engine per 1 second. After 3 seconds,I remove the rule. However,I still got “hello-world!” per second. I think there need to be a remove rule test. I have a look at the source code,the problem can be solved by adding this.prioritizedRules = null to removeRule.

Here is my code

let Engine = require('json-rules-engine').Engine
let Rule = require('json-rules-engine').Rule

let engine = new Engine()
let rule = new Rule({
  conditions: {
    all: [{
      fact: 'displayMessage',
      operator: 'equal',
      value: true
    }]
  },
  event: {
    type: 'message',
    params: {
      data: 'hello-world!'
    }
  }
})
engine.addRule(rule)
engine.addFact('displayMessage', true);
engine.on('success', (event, almanac, ruleResult) => {
  console.log(event.params.data)
})
setInterval(() => {
  engine
    .run()
}, 1000);
setTimeout(() => {
  console.log('remove');
  engine.removeRule(rule);
}, 3000)

[CacheControl]

@ozanerturk thanks for checking into this, and the offer to implement a fix.

I agree with your assessment. I think a good fix would be to add a line for setting the prioritizedRules variable to null, similar to how addRule() does it:

https://github.com/CacheControl/json-rules-engine/blob/5ac00eafdf84eb93def58a44008e96bf7bd81bf4/src/engine.js#L56

[ozanerturk]

I checked the scenario @hehejiuhuizhe seems rigth. I came across with same result. when I debugged the code I realize run method calls prioritizeRules() and it returns directly priotizedRules object if the priotizedRules list is not empty. Despite removeRule() does not clear the priotizedRules list. So even if you call removeRule() , run method is first looking to priotizedRules list to do the job and because removeRule does not clear the list there is still available rule in priotizedRules list.

https://github.com/CacheControl/json-rules-engine/blob/5ac00eafdf84eb93def58a44008e96bf7bd81bf4/src/engine.js#L146

https://github.com/CacheControl/json-rules-engine/blob/5ac00eafdf84eb93def58a44008e96bf7bd81bf4/src/engine.js#L64

Simply little cache mechanizm brokes it. The list has to be recreated after removeRule method called or force to create new one in prioritizeRules method. @CacheControl if you think this is the reason I can implement the fix if we agree on an idea.