Adding own dependency

Hey,

I’m trying to add a dependency with maven.

My dependencies in the pom.xml looks like this:

<dependencies>
        <dependency>
            <groupId>org.lambadaframework</groupId>
            <artifactId>runtime</artifactId>
            <version>${lambada.version}</version>
        </dependency>
        <dependency>
            <groupId>com.amazonaws</groupId>
            <artifactId>aws-lambda-java-log4j</artifactId>
            <version>1.0.0</version>
        </dependency>
        <dependency>
            <groupId>com.amazonaws</groupId>
            <artifactId>aws-lambda-java-events</artifactId>
            <version>1.3.0</version>
        </dependency>
        <dependency>
            <groupId>org.json</groupId>
            <artifactId>json</artifactId>
            <version>20160810</version>
        </dependency>
        <dependency>
            <groupId>junit</groupId>
            <artifactId>junit</artifactId>
            <version>4.12</version>
            <scope>test</scope>
        </dependency>
    </dependencies>

It’s the dependency json.org that won’t work.

The Error I receive is :

 A required class was missing while executing org.lambadaframework:lambada-maven-plugin:0.0.6:deploy: org/json/JSONObject

[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import  from realm ClassRealm[project>se.some.project:project-test:0.0.6, parent: ClassRealm[maven.api, parent: null]]]
[ERROR] 
[ERROR] -----------------------------------------------------: org.json.JSONObject

I did suspect that it’s the maven-shade-pluginthat causes the problem but the log clearly states that it’s included in the shaded jar:

Including org.json:json:jar:20160810 in the shaded jar.

Local maven set up

Maven home: /opt/apache-maven-3.3.9
Java version: 1.8.0_102, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_102.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12", arch: "x86_64", family: "mac"

Is it possible to add dependencies?

Thanks!

//Jonathan

[cagataygurturk]

No, of course it won’t crash with other dependencies. This is obviously a JSON library specific error, I’ll investigate the root cause. With other dependencies you should not experience any issue in theory.

[arranubels]

I have tested the above, it works. Also I made the lambada maven plugin dependency the project itself, that also worked. Doing that you don’t need to duplicate all your dependencies.

            <plugin>
                <groupId>org.lambadaframework</groupId>
                <artifactId>lambada-maven-plugin</artifactId>
                <version>${lambada.version}</version>
                <configuration>
                    <packageName>${deployment.package}</packageName>
                    <regionToDeploy>${deployment.region}</regionToDeploy>
                    <stageToDeploy>${deployment.stage}</stageToDeploy>
                    <lambdaMaximumExecutionTime>${deployment.maximumExecutionTime}</lambdaMaximumExecutionTime>
                    <lambdaMemorySize>${deployment.lambdaMemorySize}</lambdaMemorySize>
                </configuration>
        <dependencies>
        <dependency>
            <groupId>org.lambadaframework</groupId>
            <artifactId>boilerplate</artifactId>
            <version>0.0.6</version>
        </dependency>
        </dependencies>

See: https://github.com/arranubels/lambadaframework-boilerplate/blob/example1.2/pom.xml

We should probably add this to the boiler plate. I’ll send a PR.