question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Switch to eslint and prettier

See original GitHub issue

Let’s do that!

I’m not agree with the rules, that standard js dictates, but this is another story. The reason why I suggesting this is because eslint + prettier will produce match more better dev experience. Standardjs has a slogan ‘No decisions to make’, but that is really not true.

If you look at standard docs or the code of logdown you will see eslint comments everywhere. So we are know exactly what decision was made and we are depending on that decision. According to this the standard lib has no sense. There is no encapsulation and moreover configs can not be completely avoided (e.g. ignore config), so in the end result standard is half-hearted solution (at least in the modern world). Better to use eslint directly (we can set up exactly the same rules). It will provide better IDE integration, because everyone has eslint extension installed. Another one good thing is that we will be able to remove /* eslint-env jest */ comments and use eslint overrides instead.

Additionally we can add precommit hooks, that will ensure, that we are commiting linted and pushing tested code.

Issue Analytics

  • State:open
  • Created 6 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
lipiscommented, Dec 26, 2017

@bennyn here you go: #104 😃

0reactions
stale[bot]commented, Jan 25, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Integrating with Linters - Prettier
Linters. Luckily it's easy to turn off rules that conflict or are unnecessary with Prettier, by using these pre-made configs: eslint-config-prettier. stylelint ...
Read more >
How to use Prettier with ESLint - Robin Wieruch
We will start by installing the Prettier and ESLint extension/plugin for your editor/IDE. For instance, in VSCode you can find Prettier and ...
Read more >
How to use Prettier with ESLint and TypeScript in VSCode
You can see what the command is by typing COMMAND + SHIFT + P and entering "format". The command to format the current...
Read more >
Using Prettier and ESLint to automate formatting and fixing ...
Learn how to use ESLint and Prettier together to automatically format and fix JavaScript code ... Switch between multiple versions of Node ...
Read more >
Airbnb, ESLint, Prettier conflict over Switch and Case indentation
Getting Prettier, ESLint & VS Code to work harmoniously together is a very involved task, especially for first timers.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found