Globber exception when using a path with an exclamation

What You Are Seeing?

Running a cake script in a folder containing an ! (exclamation) e.g. “C:\Some ! Directory” build.cake throws an exception, “Unknown token”

What is Expected?

Glober should allow to use exclamations in a path.

What version of Cake are you using?

v0.16.2

Are you running on a 32 or 64 bit system?

x64

What environment are you running on? Windows? Linux? Mac?

Windows

Are you running on a CI Server? If so, which one?

TC, but also reproducable locally.

How Did You Get This To Happen? (Steps to Reproduce)

Running the following cake script in a folder with an exclamation, e.g. “C:\Some ! Directory”

Task("Test")
    .Does(() =>
{
    var SourceFolder = GetFiles(MakeAbsolute(Directory("./")).FullPath);
});

RunTarget("Test");

Output Log

Preparing to run build script...
Running build script...
Analyzing build script...
Processing build script...
Compiling build script...

========================================
Test
========================================
Executing task: Test
An error occured when executing task 'Test'.
Error: Unknown token
Press any key to continue . . .

[devlead]

As the globber is one of those pieces you can replace with a module, an alternative breaking way doesn’t need to break the default for every Cake user out there, but could rather be an opt-in experience. Going the contrib module path would also make it easier to do an PoC and compare default to new globber in a safe way out of band with Cake releases.

[jnm2]

I would hope that in the long term future, extglob would be supported OOB since C# developers (especially web developers) will be used to them from tooling across the board. AFAIK everything npm-based is extglob: grunt, gulp, etc. I’m not sure of the demand for non-ext globs. To be fair though, I think .gitignore and .tfignore are simple globs with the added rule that ! at the first character of the line negates the entire pattern.