replace adaptNavigationTheme with getAdaptedTheme

Is your feature request related to a problem? Please describe. adaptNavigationTheme does not work with custom Material themes and the input/output interface feels clunky.

Describe the solution you’d like within the function body of adaptNavigationTheme, there is a getAdaptedTheme function. If this were exposed instead of adaptNavigationTheme we’d have a more flexible tool.

ex implementation:

  export function getAdaptedNavigationTheme(navigationTheme: NavigationTheme, theme: MD3Theme): NavigationTheme  {
    return {
      ...navigationTheme,
      colors: {
        ...navigationTheme.colors,
        primary: theme.colors.primary,
        background: theme.colors.background,
        card: theme.colors.elevation.level2,
        text: theme.colors.onSurface,
        border: theme.colors.outline,
        notification: theme.colors.error
      }
    };
  };

Describe alternatives you’ve considered add an optional param to adaptNavigationTheme where you can provide custom light and dark MD3Themes

ex:

type OptionalMD3Theme = {
  light: MD3LightTheme;
  dark: MD3DarkTheme;
}

Additional context version: 5.0.0-rc.10

[lukewalczak]

Hey @davisk4rpi, thanks for the feedback, I see your point. I will try to refactor the utility to consider the presented case.

[lukewalczak]

Hey @davisk4rpi, I’ve raised the PR with the final approach which:

• extends adaptNavigationThemes by two new (optional) themes object properties: materialLight and materialDarkwhere you can pass your custom theme compliant with MD and Paper.
• existing properties light and dark were renamed to reactNavigationLight and reactNavigationDark

Hopefully, that approach also fits for your use case!