some ideas about exception handling

Hi @berndruecker, I have an idea about the exception handling strategy - DefaultCommandExceptionHandlingStrategy . We provide a default exception handling policy. If the user provides a custom exception handling policy, the custom policy will be activated.

• interface

public interface CommandExceptionHandlingStrategy {
  void handleCommandError(JobClient jobClient, ActivatedJob job, Throwable throwable);
}

• default handling strategy

public class DefaultCommandExceptionHandlingStrategy implements CommandExceptionHandlingStrategy {

  @Override
  public void handleCommandError(JobClient jobClient, ActivatedJob job, Throwable throwable) {
        //TODO
  }
}

• Inject DefaultCommandExceptionHandlingStrategy when missing bean

  @Bean
  @ConditionalOnMissingBean(CommandExceptionHandlingStrategy.class)
  public CommandExceptionHandlingStrategy commandExceptionHandlingStrategy() {
    return new DefaultCommandExceptionHandlingStrategy();
  }

If the user provides a custom exception handling policy, the custom policy will be activated

public class CustomCommandExceptionHandlingStrategy implements CommandExceptionHandlingStrategy {

  @Override
  public void handleCommandError(JobClient jobClient, ActivatedJob job, Throwable throwable) {
  }
}

[berndruecker]

I looked into this again - as I need conditional beans for some other thing again. I think I found a really easy way to achieve this also with pure spring:

  public static class OnMissingCommandExceptionHandlingStrategy implements Condition {
    @Override
    public boolean matches(ConditionContext context, AnnotatedTypeMetadata metadata) {
      return context.getBeanFactory().getBeanNamesForType(CommandExceptionHandlingStrategy.class).length<=0;
    }
  }

  @Bean
  @Conditional(value=OnMissingCommandExceptionHandlingStrategy.class)
  public DefaultCommandExceptionHandlingStrategy commandExceptionHandlingStrategy() {
    return new DefaultCommandExceptionHandlingStrategy(backoffSupplier(), scheduledExecutorService());
  }

@lzgabel WDYT?

[berndruecker]

Thanks for the proposal - I am not sure if I come to work on this this year, but will take it into consideration 👍