Behavior at the end of play

Hi 😃, I have some trouble playing the last seconds of my video using rx-player library. After some research I found that there is a END_OF_PLAY constant :

  /**
   * Time before the end of a video (in seconds) at which the player should
   * automatically stop.
   * It happens often that the video gets stuck 100 to 300 ms before the end,
   * especially on IE11 and Edge
   * @type {Number}
   */
  END_OF_PLAY: 0.5,

that limit the playing time of the streams

  /**
   * End-Of-Play emit when the current timing is really close to the end.
   * @see END_OF_PLAY
   * @type {Observable}
   */
  const endOfPlay = timings$
    .filter(({ currentTime, duration }) => (
      duration > 0 && duration - currentTime < END_OF_PLAY
    ));

and later

  return createAndPlugMediaSource(
    url,
    videoElement,
    withMediaSource,
    sourceBufferMemory
  )
    .mergeMap(startStream)
    .takeUntil(endOfPlay);

I have a particular use-case that requires to read the very last frame of a video. Could you change END_OF_PLAY into a configurable variable ? I also noticed that a ENDED status automatically lead to a stop action. Is it possible to disable this behavior ?

[peaBerberian]

It’s finally done and merged 🙌 !

With the release v3.2.0 you do not have to update END_OF_PLAY anymore (it does not even exist now) and we do end at the last frame of the last downloaded segment.

---

To be precize, we end at the minimum time between the end of the audio and the end of the video.

For example, if your audio ends at 10 seconds but your video ends at 11 seconds, your content will end at 10 seconds. This is a limitation of the browser, a workaround could be possible but would not be practical (at all). If that bothers you, you can still open a new issue.

---

To avoid stopping as the video ends, we had to add an option to the constructor. It is named stopAtEnd and its documentation can be found here.

---

One new thing to keep in mind however, is that we do not allow segments inferior to 200ms for various reasons. Those won’t be downloaded, won’t be pushed, and playback will happen without them (when encountered, we’ll automatically skip them).

If that is a problem for you, please open another issue.

---

Sorry for the delay, this was more complicated than expected 😞

[peaBerberian]

Current branch: https://github.com/canalplus/rx-player/tree/feat/end-of-stream

And its PR: https://github.com/canalplus/rx-player/pull/149