Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BUG] - ScaleType Problem

See original GitHub issue

🚨🚨 Before open the ticket please check if you can reproduce the bug in the sample code

Lib Version 3.3.5

Describe the bug I think that scale type is not working (Or I’m doing something wrong). When I have CropImageView with ratio for example 3x5 and I want to crop square image and im setting ScaleType to CENTER_CROP I would expect that preview of image will be filled (like in android ImageView).

To Reproduce Steps to reproduce the behavior:

In extended_activity.xml add app:cropScaleType="centerCrop" to <com.canhub.cropper.CropImageView
Run sample app
click “SAMPLE OF CUSTOM ACTIVITY”
Pick/take square photo
Go to crop screen
CropImageView is not filled

Expected behavior Image should fill whole CropImageView

Media

Smartphone (please complete the following information):

Device: xiaomi mi a 2 lite
OS: Android 9

Additional context But maybe Im doing something wrong 😄

Issue Analytics

State:
Created 2 years ago
Comments:10 (7 by maintainers)

Top GitHub Comments

1reaction

scanacommented, Mar 3, 2022

@Canato @Marchuck this is actually not the only part of code that is missing.

The thing is that together with @Marchuck we were using forked version of the old library and difference mentioned by him is actually a fix that we have implemented on our own (and never shared 🤦)

I’ll open a PR for it.

0reactions

Canatocommented, Mar 3, 2022

Thanks @scana =D