Binary incompatibilities in 1.5.1
See original GitHub issueFirst off should say that we really like the library, it’s super useful and we’re using it fairly widely (50+ projects) in our codebase at G-Research.
The latest release has a couple of binary incompatibilities in it though which are causing us some headaches, in particular this one: https://github.com/canton7/RestEase/commit/8121fd1c857d6905bf5a81c674f3315e90185b92#diff-670b79a8f3b83d14f6d9c81e7fcfcf351d19f007cd4576cb5a08a63079a83eaeR105
We’re extending the Requester
class to create an instance with baked in Polly retries using some common retry policies that make sense for our networks. I see the new comment on that class suggests we’re no longer safe to be doing this, which is a bit disappointing for a part of the public API. Is there a safe way we can continue to do what we’re doing?
Thanks, Richard
(Edited to reference the right method)
Issue Analytics
- State:
- Created 3 years ago
- Reactions:2
- Comments:7 (5 by maintainers)
Top GitHub Comments
The next version of RestEase will have
RestClient
andRestClient.For<T>
overloads which take aHttpMessageHandler
, making it easier to usePolicyHttpMessageHandler
, and the README will also contain instructions on how to do this.Closing as I think we’re done here. Feel free to reopen if you disagree.