Wrongly computed PCH header dir

For directory structure

PROJECT_DIR/
    src/
        stdafx.cxx
        stdafx.h

and project file importing those properties

  <ItemGroup>
    <ClCompile Include="src\stdafx.cxx">
      <PrecompiledHeader>Create</PrecompiledHeader>
    </ClCompile>
    <ClCompile Include="src\*.cpp" />
    <ClCompile Include="src\*.c">
      <PrecompiledHeader>NotUsing</PrecompiledHeader>
    </ClCompile>
    <ClInclude Include="src\*.hpp" />
    <ClInclude Include="src\*.h" />
  </ItemGroup>

running Tidy Code with Clang Power Tool 2.5.1 and VS2017 outputs

VERBOSE: PCH cpp name: src\stdafx.cxx
VERBOSE: PCH header name: stdafx.h
Join-Path : Cannot find path 'Disc:\...\PROJECT_DIR\stdafx.h' because it does not exist.
At C:\Users\...\VisualStudio\15.0_7afaccbd\Extensions\4zo3oigp.tpb\clang-build.ps1:524 char:25
+ ... ]] $paths = Join-Path -Path "$base" -ChildPath "$child" -Resolve -Err ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Disc:\...\PROJECT_DIR\stdafx.h:String) [Join-Path], ItemNotFoundExce 
   ption
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.JoinPathCommand

which is wrong because file is at ‘Disc:.…\PROJECT_DIR\src\stdafx.h’

Any workarounds? <PrecompiledHeaderFile> property doesn’t accept path, only filename

[hero101111]

Hello,

We’ve investigated your latest sample project and found that there are issues when project source files / headers are specified in property sheets. At the moment our project data loader is unable to load them from propsheets. We are working on a project data loader fix regarding this.

We’ll inform you when the fix will be pushed. Stay posted.

Regards, Gabriel

[Goraf]

Scenario which fails: All projects have the same directories structure

PROJECT_DIR/
    project_file
    src/
        stdafx.cxx
        stdafx.h
        <source_files>

so in a project file they import mentioned before properties

  <ItemGroup>
    <ClCompile Include="src\stdafx.cxx">
      <PrecompiledHeader>Create</PrecompiledHeader>
    </ClCompile>
    <ClCompile Include="src\*.cpp" />
    <ClCompile Include="src\*.c">
      <PrecompiledHeader>NotUsing</PrecompiledHeader>
    </ClCompile>
    <ClInclude Include="src\*.hpp" />
    <ClInclude Include="src\*.h" />
  </ItemGroup>

from a common properties sheet with an entry like <Import Project="common.props" /> And to that point fix to the script works.

Now, lets say some project has its own unique, internal library in its sources, so this project’s structure looks like

PROJECT_DIR/
    project_file
    src/
        stdafx.cxx
        stdafx.h
        <source_files>
        library/
            <library_source_files>

so it also needs additional include entries in its project file after imported common includes. Like that

  <Import Project="common.props" />
  <ItemGroup>
    <ClCompile Include="src\library\*.cpp">
      <PrecompiledHeader>NotUsing</PrecompiledHeader>
    </ClCompile>
    <ClInclude Include="src\library\*.h" />
  </ItemGroup>

And in such case script fails.

sample project.zip