question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

After adjusting line-height, code selection no longer lines up.

See original GitHub issue

Thanks for looking at this issue / thanks in advance for fixing it! I love this little project! 😄

Expected Behavior

After adjusting line-height, code selection should line up with the apparent location of the code. This would let users adjust line-height, and then continue to use the web app to create screenshots.

Actual Behavior

After adjusting line-height, code selection no longer lines up with the apparent location of the code. This makes for an unusable experience, after line-height is set. The more the line-height is changed, the worse the problem.

In the below screenshot, I have selected ALL the text (that little bump you can see at the bottom of the selection, is the closing curly brace (}) being selected.

carbon-selection-misaligned

Browser: Chrome, Brave

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

2reactions
JoeCodesStuffcommented, May 17, 2019

Haha, well of course I can do that, but I just thought you might want to fix the site to be more user friendly 😛 I’m happy with the site as it is and I use it all the time, but you have a place to submit issues, so I submitted one.

Cheers,

Joe Weaver JoeWeaver.me

On Thu, May 16, 2019 at 5:51 PM, Michael Fix notifications@github.com wrote:

@JosephWeaver this problem doesn’t seem large enough to manually keep track of the selection in code and then reapply it after the line height’s change. Can you not just reselect the lines after you update the line heights?

Line heights on there own are already a rarely used feature 🙂

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

0reactions
mfix22commented, May 17, 2019

@JosephWeaver this problem doesn’t seem large enough to manually keep track of the selection in code and then reapply it after the line height’s change. Can you not just reselect the lines after you update the line heights?

Line heights on there own are already a rarely used feature 🙂

Read more comments on GitHub >

github_iconTop Results From Across the Web

line-height - CSS: Cascading Style Sheets - MDN Web Docs
The line-height CSS property sets the height of a line box. It's commonly used to set the distance between lines of text.
Read more >
How can I fix the line-height in ordered list when the text ...
The problem now is that when the text is long and breaks in multiple lines it's too close together and I cannot find...
Read more >
line-height | CSS-Tricks
The line-height property can accept the keyword values normal or none as well as a number, length, or percentage. According to the spec,...
Read more >
How To Adjust Line Height in WordPress Gutenberg Editor
If you want to change it for the entire theme, then it would require that you edit the template and adjust the line...
Read more >
Line height behavior – Figma Help Center
Click to select all Text layers within the current page. You can then adjust the Line Height settings in the Properties Panel. Update...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found