[Audit] Dropdown

Dropdown

• Should dropdown be using listbox styles? Should we pull out listbox into a set of tools to apply styles instead of shared styles for each?

• Should use body-short-01 for placeholder text and value

• What should focus be for error state? cc @laurenmrice Currently it’s a red border

• All dropdown versions should be pulling the 16 icon. I think this is the old icon.

Inline Dropdown

• Should use body-short-01 for text

• Bounding box should have only 8px of padding on left hand side

Expected:

Actual:

• Width of control seems off from spec

Expected:

Actual:

Filterable Dropdown (Combobox), MultiSelects, etc.

These all use list-box and will most likely share updates

• Should use body-short-01 for text
• Disabled -> hover seems to still have hover color
• Need to verify in React repo for functionality

[laurenmrice]

The 8px padding for bounding box only applies for the inline dropdown. I was referring to the normal dropdowns when i mentioned 16px

[laurenmrice]

• #1896, #1989, #1793 are closed issues and are good.
• Just reviewed with changes for open issue #1987.
• For the #1749 audit issue, those listed changes for dropdown are all still valid for things that need to be fixed if they are not all ready implemented. Can I have the current link of dropdown to check if those fixes were made?
• For Combo-box and Multi-select I would need to see the latest version of those to determine if that is all that needs to be changed.