Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

"Button With icon" should have aria-hidden="true" on the svg

See original GitHub issue

The icon in a “Button With icon” is purely decorative, and as such, it (the svg) should have aria-hidden="true" so that screen readers don’t try to say something about them.

Please add aria-hidden="true" to the svg element for all of the “Xxx Button With icon” examples on the Carbon Button component page.

It might be nice if there was an “Accessibility Notes” section on the Button Component page that mentioned this, i.e. something like:

Note: The SVG in a “Button With icon” is purely decorative, and so it should have aria-hidden=“true” to hide it from Assistive Technology such as screen readers. It does not need to have a title or desc.

Issue Analytics

State:
Created 5 years ago
Comments:7 (6 by maintainers)

Top GitHub Comments

1reaction

emyarodcommented, Jan 21, 2019

hi @carmacleod thank you for opening up that ticket! I believe the docs require a manual build and deploy. at the moment I don’t have an exact date on when the site will be updated but I expect it to update sooner rather than later

1reaction

carmacleodcommented, Jan 21, 2019

Hi @emyarod. I opened https://github.com/IBM/carbon-components/issues/1667 to create an “icon only” example. I notice that the https://www.carbondesignsystem.com/components/button/code page is not yet updated with your fixes for this issue - when will that happen?