question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Carbon Tab component does not use tokens listed on Carbon website and cannot be themed correctly

See original GitHub issue

What package(s) are you using?

  • [ x] carbon-components
  • [ x] carbon-components-react

Detailed description

Describe in detail the issue you’re having. Is this a feature request (new component, new icon), a bug, or a general issue?

Is this issue related to a specific component? Yes, the Tabs component.

What did you expect to happen? What happened instead? What would you like to see changed? I expected that if I override the color for the tokens $ui-04 and $text-04 that the Tab component would update accordingly (according to the spec: https://www.carbondesignsystem.com/components/tabs/style/). Unfortunately, this documentation looks to be out of sync with the actual code and there doesn’t appear to be a relationship between the specified tokens and the component’s scss. I have screenshots below.

What browser are you working in? Chrome

What version of the Carbon Design System are you using? 10.5.1

What offering/product do you work on? Any pressing ship or release dates we should be aware of? IBM Marketplace

Steps to reproduce the issue

It’s pretty straightforward to modify the theme at http://themes.carbondesignsystem.com/?nav=tabs and see that the new theme colors don’t apply to the Tabs.

  1. Override $ui-04 or $text-04 with custom colors
  2. Check the tab component and see the colors haven’t updated.
  3. To confirm that theming does indeed work, you can override $focus or $interactive-01

Additional information

Ping me on Slack if there’s anything I can help debug.

Screen Shot 2019-08-26 at 1 02 25 PM Screen Shot 2019-08-26 at 1 02 35 PM Screen Shot 2019-08-26 at 1 06 49 PM

Add labels

Please choose the appropriate label(s) from our existing label list to ensure that your issue is properly categorized. This will help us to better understand and address your issue.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
tw15egancommented, Aug 26, 2019

Thanks for clarifying @laurenmrice. So looks like we’ll just need to update the color token for the hover text color on the website, and I’ll make these other updates here in the code 👍

0reactions
laurenmricecommented, Aug 26, 2019

the text color on hover should be text-01 the hover border-bottom color should be ui-04 (Gray 50)

As for the other values they should have tokens: tab-underline-color should be ui-03 (Gray 20) tab-text-disabled should be disabled-02 tab-underline-disabled should be disabled-01

Read more comments on GitHub >

github_iconTop Results From Across the Web

Question about theming · Issue #6088 · carbon-design-system ...
I'm using Angular for my project, and I successfully imported the carbon theme in my main .scss file: @import "~carbon-components/scss/globals/ ...
Read more >
Themes - Carbon Design System
Themes are used to customize component styles to fit the specific aesthetic of a brand or product. Theming basics; Customizing a theme; Tokens;...
Read more >
Newest 'carbon-design-system' Questions - Stack Overflow
I would like to use carbon design motion in a react project. ... overriding the default theme (white) with their design tokens so...
Read more >
@carbon/ibmdotcom-web-components - npm
The names of CSS Custom Properties you can use are the Carbon theme tokens prefixed with --cds- . The list of Carbon theme...
Read more >
Minimal CSS with Carbon - Medium
We're the design system for IBM, shipping open-source styles and components in Vanilla, React, Angular, and Vue for anyone building on the web....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found