Conduct prop audit as a team
See original GitHub issueThis issue is to conduct a prop audit as a team and determine next steps for prop conventions or renames for the next major release.
Topics to discuss:
- Conventions for
className
- Conventions for
ref
- Conventions for event handler signatures
- Convention for
open
vsisOpen
- Convention for
render*
props - Convention for
aria-label
vslabel
- Convention for
size
variants- Do we use a
size
prop, or is the size itself a prop?
- Do we use a
Related issues:
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:5 (4 by maintainers)
Top Results From Across the Web
How to Be a Good Auditor as a Team Leader
Review the audit rules and the process with your team to make sure everyone knows how he should operate. Discuss any concerns, and...
Read more >5 Expert Steps for You to Get Your Audit Right | Process Street
Assign work to audit team. 18. Initiating the audit: 19. Make arrangements with the auditee. 20. Conduct open meeting.
Read more >Conducting Human Resource Audits - SHRM
HR usually conducts an audit by using a questionnaire that asks for the evaluation of specific practice areas. This document helps guide the...
Read more >Real Estate Audit: What Is It and How to Prepare for One
Gather the proper documentation. This typically includes financial statements, transaction documents, property listings, details of trust accounts, property ...
Read more >Section 3. Auditing and Related Professional Practice Standards
A registered public accounting firm and its associated persons shall comply with all applicable auditing and related professional practice standards.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@metonym thanks for the input! Love these ideas.
Only one note, for the shortening prop name step I believe we’ll move forward with
isFixed
instead offixed
. The rationale being that lowercase prop names can be confused with DOM attributes in some cases. There is also confusion as to if states named similarly to something likeactive
correspond to the initial state or the current state. This is something whichis*
can help to address as a naming convention 👍We can definitely do this on a case-by-case basis, but might make more sense just to have one convention across the codebase so the API becomes more guess-able instead of being component-specific.
Going to close this in favor specific audit lists 👀