question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Data Table with Checkbox column example needs accessibility improvements

See original GitHub issue

Copied from https://github.com/carbon-design-system/design-system-website/issues/286

@carmacleod

The Data Table with Checkbox column example needs a few improvements (some for accessibility, some are just invalid markup):

  1. Download, Edit, and Settings buttons image
  • the <svg> element does not support the alt attribute, so for these 3 buttons, the alt="xxx" should just be deleted.
  • the svg’s <title> is redundant with the aria-label and it is being read twice by some screen readers, so instead of aria-label, please use aria-labelledby to point to the id of the svg’s title element. Alternatively, you can delete the title element completely and use a custom tooltip instead of using title as the tooltip. If you do the latter (custom tooltips look nicer) then please use aria-labelledby to point to the id of the element containing the custom tooltip’s text.
  1. Similar to the above, the Overflow buttons could use a tooltip to explain the “kebab icon” to users who can’t guess what it is for. 😃 image
  • either with svg’s title element, and use aria-labelledby to point to the title element’s id
  • or using a custom tooltip, and use aria-labelledby to point to the element containing the text
  • (other overflow menu issues covered in #666)
  1. The table header elements need scope="col" so that screen readers know that they are column headers, and not row headers, i.e.: <th scope="col">

  2. The checkbox column image

  • has 2 different DAP violations for each checkbox: – Each form control must have associated label. (g41) – Provide descriptive text in label elements. (g1055)

image

  • need to work with the DAP folks to figure out what the most accessible (and valid) markup is for form controls inside a data table

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:1
  • Comments:10 (4 by maintainers)

github_iconTop GitHub Comments

3reactions
GabrieleBarbonicommented, Jun 12, 2019

Still needed

1reaction
GabrieleBarbonicommented, May 3, 2019

still needed

Read more comments on GitHub >

github_iconTop Results From Across the Web

Data Table with Checkbox column example needs ... - GitHub
Data Table with Checkbox column example needs accessibility ... Checkbox column example needs a few improvements (some for accessibility, ...
Read more >
Example: Checkbox select column
Sample Data. This example will use a local Javascript array of data that includes some common Internet port socket numbers and protocol names:...
Read more >
Forms within tables - ADG - the Accessibility Developer Guide!
Forms in tables only make sense if they are handling data that has a tabular structure itself. It is important that the table...
Read more >
jQuery DataTables: Row selection using checkboxes
In this article we will try to describe universal solution to add a checkbox column to a table and allow multiple row selection...
Read more >
New Features and More Accessible Data Tables | by Karen ...
Information on Display: New Features and More Accessible Data Tables. Updated interactions, new customizations and expanded access for users—dig ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found